Re: [PATCH] check for This->frame

[Jacek Caban]

Hi Marcus,

Marcus Meissner wrote:
> Hi,
>
> Coverity 645 spotted missing This->frame
> checks.
> Ciao, Marcus
>
> dlls/mshtml/olecmd.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/mshtml/olecmd.c b/dlls/mshtml/olecmd.c
> index 326b0b0..02b5e83 100644
> --- a/dlls/mshtml/olecmd.c
> +++ b/dlls/mshtml/olecmd.c
> @@ -621,7 +621,7 @@ static HRESULT exec_editmode(HTMLDocument *This, DWORD cmdexecopt, VARIANT *in,
>          if(This->hostui)
>              IDocHostUIHandler_HideUI(This->hostui);
> -
>    if(This->hostui)
> -
>    if(This->hostui && This->frame)
>        IDocHostUIHandler_ShowUI(This->hostui, DOCHOSTUITYPE_AUTHOR, ACTOBJ(This), CMDTARGET(This),
>            This->frame, This->ip_window);

There is no reason to test This->frame here (unless you have tested that 
native MSHTML doesn't call ShowUI with NULL frame). Coverity spotted an 
other bug, which you've fixed in other part of the patch.

Thanks,
    Jacek