Re: winex11.drv: Windows always generates VK_DECIMAL for Del/. on a keypad.

[Dmitry Timoshkov]

Dmitry Timoshkov  wrote:
> Windows always generates VK_DECIMAL for Del/. on a keypad while some
> X11 keyboard layouts generate XK_KP_Separator instead of XK_KP_Decimal
> in order to produce a locale dependent numeric separator.
>
> X11 handles XK_KP_Separator same way as XK_KP_Decimal for all tested
> keyboard layouts, so passing XK_KP_Separator instead of XK_KP_Decimal
> to XKeysymToKeycode doesn't break things. Pressing Del/. with NumLock
> turned on still correctly generates '.' or ',' depending on keyboard
> layout and matches what Windows does.
>
> This patch fixes an application which uses VK_DECIMAL as a sign to break
> the input string and insert a separator while entering a currency/price.

Is there anything else I could provide in helping to get this patch accepted?

winex11.drv: Windows always generates VK_DECIMAL for Del/. on a keypad.

[Dmitry Timoshkov]

Dmitry Timoshkov  wrote:
> > Windows always generates VK_DECIMAL for Del/. on a keypad while some
> > X11 keyboard layouts generate XK_KP_Separator instead of XK_KP_Decimal
> > in order to produce a locale dependent numeric separator.
> >
> > X11 handles XK_KP_Separator same way as XK_KP_Decimal for all tested
> > keyboard layouts, so passing XK_KP_Separator instead of XK_KP_Decimal
> > to XKeysymToKeycode doesn't break things. Pressing Del/. with NumLock
> > turned on still correctly generates '.' or ',' depending on keyboard
> > layout and matches what Windows does.
> >
> > This patch fixes an application which uses VK_DECIMAL as a sign to break
> > the input string and insert a separator while entering a currency/price.
>
> Is there anything else I could provide in helping to get this patch accepted?

Any feedback on this?