The sticky <th> header row often has a different height depending on the platform page being accessed. This prevents us from hard-coding the scroll-margin-top property using CSS alone. Dynamically setting this value ensures each bookmark is shown as expected.
--- winetest/gather | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/winetest/gather b/winetest/gather index 4698ac3..b4526bf 100755 --- a/winetest/gather +++ b/winetest/gather @@ -911,6 +911,12 @@ EOF To run the tests on your Windows machine, download the <a href="/builds/winetest-$short_build.exe">32-bit winetest</a>. If you have a 64-bit Windows OS, you can also run the <a href="/builds/winetest64-$short_build.exe">64-bit winetest</a>. </div> +<script> + var sticky_height = document.querySelector('.sticky').offsetHeight + 1; + var style = document.createElement('style'); + style.innerHTML = 'div.group table.report td.test a { scroll-margin-top: ' + sticky_height + 'px; }'; + document.head.appendChild(style); +</script> </body> </html> EOF
Hi,
On Mon, 3 May 2021, Hugh McMaster wrote:
The sticky <th> header row often has a different height depending on the platform page being accessed. This prevents us from hard-coding the scroll-margin-top property using CSS alone. Dynamically setting this value ensures each bookmark is shown as expected.
So, if I understand correctly, this is so that when following a link such as the one below, the 'd3d11:d3d11' line id not hidden behind the sticky header.
https://test.winehq.org/data/e2aa30f21def839866b09e74b5ddd843f7e70c87/index_...
But even without this chunk of JavaScript I'm not seeing this issue, neither in Firefox, nor in Chromium.
Did I miss something?