Re: wine-devel Digest, Vol 14, Issue 93

[Anton Litvinov]

----- Original Message ----- 
From: 
To: 
Sent: Friday, September 29, 2006 8:58 PM
Subject: wine-devel Digest, Vol 14, Issue 93
> Send wine-devel mailing list submissions to
> [e-mail]
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://www.winehq.org/mailman/listinfo/wine-devel
> or, via email, send a message with subject or body 'help' to
> [e-mail]
>
> You can reach the person managing the list at
> [e-mail]
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of wine-devel digest..."
>
> Today's Topics:
> - Re: Governance Ideas (Mike McCormack)
> - Re: shdocvw(2/2): ignore VT_ERROR arguments to
> WebBrowser_Navigate2 (Michael Stefaniuc)
> - Re: make test failure (Michael Stefaniuc)
> - Re: [D3D9] Remove const qualifier on state_test data.
> (Michael Stefaniuc)
> - compiling wine for amd64 on ubuntu dapper 6.06 (Gerald Britton)
> - Re: make test failure (Vitaliy Margolen)
> - Re: shdocvw(2/2): ignore VT_ERROR arguments to
> WebBrowser_Navigate2 (Juan Lang)
> - Re: USER32: Stub implementation of BlockInput (Juan Lang)
>
> Message: 1
> Date: Fri, 29 Sep 2006 18:02:08 +0900
> From: Mike McCormack 
> Subject: Re: Governance Ideas
> To: [e-mail]
> Cc: [e-mail], Alexandre Julliard 
> Message-ID: 
> Content-Type: text/plain; charset=us-ascii; format=flowed
>
> Robert Lunnon wrote:
> > "Community Focused Process" means what it says, develop a process which

is
> > centred on the community the project serves. This requires the project

to
> > answer some introspective questions
> > - Who "owns"  Wine, does wine belong to A.)  Alexandre, or B) the

community
> > it serves.
>
> A) Alexandre is a benelovent dictator.  He manages Wine with the
> interests of "the community" in mind, as he sees them.
> > - Answer the questions about the "ownership" of wine and identify the
> >
> > community it serves. Determine the right of the community to be involved

is
> > setting wines direction IE The Bill of rights I mentioned before (for

each
> > community Developers VS Users etc).
>
> Your "bill of rights" is the Wine license, the LGPL.
> > - Alexandre documents the exact logic he uses to determine patch
> >
> > acceptability which becomes the patch acceptance policy in the interim.
>
> It's very likely impossible to write that down.  If you don't agree with
> me, please write down your proposal.
> > - The project develops a community process for establishing project

direction
> > and maintaining the patch acceptance policy which includes stakeholders
> > elected from the "owners" IE communities with a stakeholding in wine
>
> NetBSD is a project that is (was?) run by committees:
>
> http://mail-index.netbsd.org/netbsd-users/2006/08/30/0016.html
>
> If you want Wine to be run by a committee, how about creating your own
> fork so you can run it as you see fit?
>
> Mike
>
> Message: 2
> Date: Fri, 29 Sep 2006 10:57:26 +0200
> From: Michael Stefaniuc 
> Subject: Re: shdocvw(2/2): ignore VT_ERROR arguments to
> WebBrowser_Navigate2
> To: [e-mail]
> Cc: [e-mail]
> Message-ID: 
> Content-Type: text/plain; charset=UTF-8
>
> Juan Lang wrote:
> > Combined with the first patch, I'm able to log in with Skype 2.6 beta.
> >
> > ChangeLog: ignore VT_ERROR arguments to WebBrowser_Navigate2
>
> Ignoring VT_ERROR just masks a previous error.
>
> bye
> michael
> > Index: dlls/shdocvw/webbrowser.c
> >
> > RCS file: /home/wine/wine/dlls/shdocvw/webbrowser.c,v
> > retrieving revision 1.65
> > diff -u -r1.65 webbrowser.c
> > --- dlls/shdocvw/webbrowser.c 25 Sep 2006 19:46:43 -0000 1.65
> > +++ dlls/shdocvw/webbrowser.c 29 Sep 2006 00:55:46 -0000
> > @@ -675,7 +675,7 @@
> >      if(V_VT(URL) != VT_BSTR)
> >          return E_INVALIDARG;
> > - if(PostData && V_VT(PostData) != VT_EMPTY) {
> > - if(PostData && V_VT(PostData) != VT_EMPTY && V_VT(PostData) !=

VT_ERROR) {
> >      if(V_VT(PostData) != (VT_ARRAY | VT_UI1)
> >         || V_ARRAY(PostData)->cDims != 1) {
> >          WARN("Invalid PostData\n");
> >
> > @@ -686,7 +686,7 @@
> >          post_data_len = V_ARRAY(PostData)->rgsabound[0].cElements;
> >      }
> > - if(Headers && V_VT(Headers) != VT_EMPTY) {
> > - if(Headers && V_VT(Headers) != VT_EMPTY && V_VT(Headers) !=

VT_ERROR) {
> >      if(V_VT(Headers) != VT_BSTR)
> >          return E_INVALIDARG;
>
> -- 
> Michael Stefaniuc               Tel.: [phone]
> Sr. Network Engineer            Fax.: [phone]
> Red Hat GmbH                    Email: [e-mail]
> Hauptstaetterstr. 58            http://www.redhat.de/
> D-70178 Stuttgart
>
> Message: 3
> Date: Fri, 29 Sep 2006 10:59:02 +0200
> From: Michael Stefaniuc 
> Subject: Re: make test failure
> To: [e-mail]
> Message-ID: 
> Content-Type: text/plain; charset=UTF-8
>
> James Hawkins wrote:
> > On 9/28/06, Vitaliy Margolen  wrote:
> > > James Hawkins wrote:
> > > > On 9/28/06, Paul Vriens  wrote:
> > > > > On Thu, 2006-09-28 at 11:27 -0700, James Hawkins wrote:
> > > > > > Hi,
> > > > > >
> > > > > > Running make test fails with:
> > > > > >
> > > > > > make[2]: Entering directory
> > >
> > > `/usr/local/src/wine/dlls/comctl32/tests'
> > > > > > ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p
> > > > > > comctl32_test.exe.so tab.c && touch tab.ok
> > > > > > tab.c:184: Test failed: no icon, set size: Expected [44,20] got
> > >
> > > [56,20]
> > > > > > tab.c:208: Test failed: no icon, set size: Expected [42,20] got
> > >
> > > [54,20]
> > > > > > tab.c:184: Test failed: no icon, set size: Expected [44,20] got
> > >
> > > [56,20]
> > > > > > tab.c:208: Test failed: no icon, set size: Expected [42,20] got
> > >
> > > [54,20]
> > > > > > tab.c:184: Test failed: no icon, set size: Expected [44,20] got
> > >
> > > [56,20]
> > > > > > tab.c:184: Test failed: no icon, set size: Expected [54,20] got
> > >
> > > [56,20]
> > > > > > make[2]: *** [tab.ok] Error 6
> > > > >
> > > > > Succeeds over here.
> > > >
> > > > I know, it succeeds on a lot of machines, but the point is that it
> > > > shouldn't fail on any machine.
> > >
> > > Please remove your ~/.wine dir and try again. It seems your metrics are
> > > set different. Or your fonts are wrong.
> >
> > The tests still fail with a clean .wine.
>
> Yes, i used an empty .wine too.
>
> bye
> michael
> -- 
> Michael Stefaniuc               Tel.: [phone]
> Sr. Network Engineer            Fax.: [phone]
> Red Hat GmbH                    Email: [e-mail]
> Hauptstaetterstr. 58            http://www.redhat.de/
> D-70178 Stuttgart
>
> Message: 4
> Date: Fri, 29 Sep 2006 12:33:27 +0200
> From: Michael Stefaniuc 
> Subject: Re: [D3D9] Remove const qualifier on state_test data.
> To: [e-mail]
> Cc: [e-mail]
> Message-ID: 
> Content-Type: text/plain; charset=UTF-8
>
> Ivan Gyurdiev wrote:
> > Type: Cleanup
> >
> > Why:
> > The const qualifier is unnecessarily restrictive.
> > I intend to allocate and free such data on the heap in a future patch.
> > Instead, const should be primarily used on function parameters.
>
> Question: do you realy have to use void pointers? Void pointers are
> compatible with every pointer type and thus will disable the type
> checking of the compiler. Also you do not need to to cast a rvalue to
> void * if the type of the lvalue is void *.
>
> bye
> michael
> > dlls/d3d9/tests/stateblock.c |   40

++++++++++++++++++++--------------------
> > 1 files changed, 20 insertions(+), 20 deletions(-)
> >
> > diff --git a/dlls/d3d9/tests/stateblock.c b/dlls/d3d9/tests/stateblock.c
> > index 65a11e6..68b431a 100644
> > --- a/dlls/d3d9/tests/stateblock.c
> > +++ b/dlls/d3d9/tests/stateblock.c
> > @@ -105,20 +105,20 @@ typedef struct state_test {
> >       * as the default data, but a write can have side effects.
> >       * The initial data is tested first, before any writes take place
> >       * The default data can be tested after a write */
> > - const void* initial_data;
> > -
> >
> > void* initial_data;
> >
> > /* The default data is the standard state to compare
> > - against, and restore to */
> > - const void* default_data;
> > -
> >
> > void* default_data;
> >
> > /* The test data is the experiment data to try
> > - in - what we want to write
> > - out - what windows will actually write (not necessarily the

same)  */
> > - const void* test_data_in;
> > - const void* test_data_out;
> > -
> >
> > void* test_data_in;
> > -
> >
> > void* test_data_out;
> >
> > /* The poison data is the data to preinitialize the return buffer

to */
> > - const void* poison_data;
> > -
> >
> > void* poison_data;
> >
> > /* Return buffer */
> > void* return_data;
> >
> > @@ -562,11 +562,11 @@ static void shader_constants_queue_test(
> >      shader_constant_arg* arg = buffer;
> >      shader_constant_data* return_data = (shader_constant_data*) (arg +

1);
> > - test->test_data_in = &shader_constant_test_data;
> > - test->test_data_out = &shader_constant_test_data;
> > - test->default_data = &shader_constant_default_data;
> > - test->initial_data = &shader_constant_default_data;
> > - test->poison_data = &shader_constant_poison_data;
> > - test->test_data_in = (void*) &shader_constant_test_data;
> > - test->test_data_out = (void*) &shader_constant_test_data;
> > - test->default_data = (void*) &shader_constant_default_data;
> > - test->initial_data = (void*) &shader_constant_default_data;
> > - test->poison_data = (void*) &shader_constant_poison_data;
> > test->return_data = return_data;
> > test->data_size = sizeof(shader_constant_data);
> > test->set_handler = shader_constant_set_handler;
> >
> > @@ -697,11 +697,11 @@ static void lights_queue_test(
> >      light_arg* arg = buffer;
> >      light_data* return_data = (light_data*) (arg + 1);
> > - test->test_data_in = &light_test_data_in;
> > - test->test_data_out = &light_test_data_out;
> > - test->default_data = &light_default_data;
> > - test->initial_data = &light_initial_data;
> > - test->poison_data = &light_poison_data;
> > - test->test_data_in = (void*) &light_test_data_in;
> > - test->test_data_out = (void*) &light_test_data_out;
> > - test->default_data = (void*) &light_default_data;
> > - test->initial_data = (void*) &light_initial_data;
> > - test->poison_data = (void*) &light_poison_data;
> > test->return_data = return_data;
> > test->data_size = sizeof(light_data);
> > test->set_handler = light_set_handler;
> >
> > @@ -856,11 +856,11 @@ static void transform_queue_test(
> >  {
> >      transform_data* return_data = buffer;
> > - test->test_data_in = &transform_test_data;
> > - test->test_data_out = &transform_test_data;
> > - test->default_data = &transform_default_data;
> > - test->initial_data = &transform_default_data;
> > - test->poison_data = &transform_poison_data;
> > - test->test_data_in = (void*) &transform_test_data;
> > - test->test_data_out = (void*) &transform_test_data;
> > - test->default_data = (void*) &transform_default_data;
> > - test->initial_data = (void*) &transform_default_data;
> > - test->poison_data = (void*) &transform_poison_data;
> > test->return_data = return_data;
> > test->data_size = sizeof(transform_data);
> > test->set_handler = transform_set_handler;
>
> -- 
> Michael Stefaniuc               Tel.: [phone]
> Sr. Network Engineer            Fax.: [phone]
> Red Hat GmbH                    Email: [e-mail]
> Hauptstaetterstr. 58            http://www.redhat.de/
> D-70178 Stuttgart
>
> Message: 5
> Date: Fri, 29 Sep 2006 09:06:48 -0400
> From: "Gerald Britton" 
> Subject: compiling wine for amd64 on ubuntu dapper 6.06
> To: [e-mail]
> Message-ID:
>
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>
> Hi -- I'm trying to get wine going on my ubuntu dapper installation on
> an amd 64 box. I have followed the wiki instructions in
> http://wiki.winehq.org/WineOn64bit for ubuntu and rechecked my work.
> Two things go wrong:
> - /configure can't find opengl, and produces these messages:
>
> configure: WARNING: Wine will be build without OpenGL or Direct3D support
> configure: WARNING: because something is wrong with the OpenGL setup:
> configure: WARNING: No OpenGL library found on this system.
> - make depend works, but make all fails with this:
>
> LD_LIBRARY_PATH="../../libs/wine:$LD_LIBRARY_PATH" ../../tools/wrc/wrc
> --nostdinc -I. -I. -I../../include -I../../include
> -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_  -foversion.res
> version.rc
> ../../tools/winegcc/winegcc -B../../tools/winebuild -shared
> ./gdi32.spec dispdib.spec.o gdi.exe.spec.o wing.spec.o bidi16.o
> dispdib.o env.o gdi16.o metafile16.o wing.o  bidi.o bitblt.o bitmap.o
> brush.o clipping.o dc.o dib.o driver.o enhmetafile.o enhmfdrv/bitblt.o
> enhmfdrv/dc.o enhmfdrv/graphics.o enhmfdrv/init.o enhmfdrv/mapping.o
> enhmfdrv/objects.o font.o freetype.o gdi_main.o gdiobj.o icm.o
> mapping.o metafile.o mfdrv/bitblt.o mfdrv/dc.o mfdrv/graphics.o
> mfdrv/init.o mfdrv/mapping.o mfdrv/objects.o mfdrv/text.o painting.o
> palette.o path.o pen.o printdrv.o region.o    version.res   -o
> gdi32.dll.so  -ladvapi32 -lkernel32 -lntdll  /usr/lib/libsicuuc.a
> /usr/lib/libsicudata.a -lstdc++ -lgcc_s ../../libs/port/libwine_port.a
> -L/lib32 -L/usr/lib32 -Wl,-rpath,/lib32 -Wl,-rpath,/usr/lib32
> ld: Relocatable linking with relocations from format elf64-x86-64
> (/usr/lib/libsicuuc.a(ubidi.ao)) to format elf32-i386 (gdi32.ArPHdq.o)
> is not supported
> winebuild: ld -m elf_i386 -r failed with status 256
> winegcc: ../../tools/winebuild/winebuild failed.
> make[2]: *** [gdi32.dll.so] Error 2
> make[2]: Leaving directory `/tmp/wine-0.9.22/dlls/gdi'
> make[1]: *** [gdi] Error 2
> make[1]: Leaving directory `/tmp/wine-0.9.22/dlls'
> make: *** [dlls] Error 2
>
> I'm not sure what to do now.  Any feedback/suggestions would be

appreciated.
> Message: 6
> Date: Fri, 29 Sep 2006 07:36:58 -0600
> From: Vitaliy Margolen 
> Subject: Re: make test failure
> To: [e-mail]
> Message-ID: 
> Content-Type: text/plain; charset=UTF-8
>
> Michael Stefaniuc wrote:
> > James Hawkins wrote:
> > > On 9/28/06, Vitaliy Margolen  wrote:
> > > > James Hawkins wrote:
> > > > > On 9/28/06, Paul Vriens  wrote:
> > > > > > On Thu, 2006-09-28 at 11:27 -0700, James Hawkins wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > Running make test fails with:
> > > > > > >
> > > > > > > make[2]: Entering directory
> > > >
> > > > `/usr/local/src/wine/dlls/comctl32/tests'
> > > > > > > ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p
> > > > > > > comctl32_test.exe.so tab.c && touch tab.ok
> > > > > > > tab.c:184: Test failed: no icon, set size: Expected [44,20] got
> > > >
> > > > [56,20]
> > > > > > > tab.c:208: Test failed: no icon, set size: Expected [42,20] got
> > > >
> > > > [54,20]
> > > > > > > tab.c:184: Test failed: no icon, set size: Expected [44,20] got
> > > >
> > > > [56,20]
> > > > > > > tab.c:208: Test failed: no icon, set size: Expected [42,20] got
> > > >
> > > > [54,20]
> > > > > > > tab.c:184: Test failed: no icon, set size: Expected [44,20] got
> > > >
> > > > [56,20]
> > > > > > > tab.c:184: Test failed: no icon, set size: Expected [54,20] got
> > > >
> > > > [56,20]
> > > > > > > make[2]: *** [tab.ok] Error 6
> > > > > > >
> > > > > > Succeeds over here.
> > > > >
> > > > > I know, it succeeds on a lot of machines, but the point is that it
> > > > > shouldn't fail on any machine.
> > > >
> > > > Please remove your ~/.wine dir and try again. It seems your metrics

are
> > > > set different. Or your fonts are wrong.
> > >
> > > The tests still fail with a clean .wine.
> >
> > Yes, i used an empty .wine too.
>
> And you guys have windows like "Arial" font? Any test that uses fonts
> will not work if you don't have that font or it's not the same metrics
> as the native one.
>
> Vitaliy.
>
> Message: 7
> Date: Fri, 29 Sep 2006 08:36:46 -0700 (PDT)
> From: Juan Lang 
> Subject: Re: shdocvw(2/2): ignore VT_ERROR arguments to
> WebBrowser_Navigate2
> To: Michael Stefaniuc 
> Cc: [e-mail]
> Message-ID: 
> Content-Type: text/plain; charset=iso-8859-1
> > Ignoring VT_ERROR just masks a previous error.
>
> Hm.. are you sure?  These are input arguments, not results.  This isn't
> the only app that gets further with this patch.  See also bug 6166.
>
> I guess a test case is the only answer.
>
> --Juan
>
> Do You Yahoo!?
> Tired of spam?  Yahoo! Mail has the best spam protection around
> http://mail.yahoo.com
>
> Message: 8
> Date: Fri, 29 Sep 2006 09:57:35 -0700 (PDT)
> From: Juan Lang 
> Subject: Re: USER32: Stub implementation of BlockInput
> To: Jason Green 
> Cc: [e-mail]
> Message-ID: 
> Content-Type: text/plain; charset=iso-8859-1
>
> You forgot the patch..
>
> --Juan
>
> Do You Yahoo!?
> Tired of spam?  Yahoo! Mail has the best spam protection around
> http://mail.yahoo.com
>
> wine-devel mailing list  -  [e-mail]
> http://www.winehq.org/mailman/listinfo/wine-devel
>
> End of wine-devel Digest, Vol 14, Issue 93