I don't have a particular app for you, however, there can easily be apps that would behave differently from how they would on Windows due to these last errors not being set to what the app expects. Do you have a reason why Wine behavior should not match the Windows behavior in these test cases? By Windows behavior I am referring to the more recent Windows versions of course.
Dmitry
--- On Thu, 4/23/09, Paul Vriens paul.vriens.wine@gmail.com wrote:
From: Paul Vriens paul.vriens.wine@gmail.com Subject: Re: kernel32/tests: Added last error tests for GetPrivateProfileString To: dimaki@rocketmail.com Cc: wine-devel@winehq.org Date: Thursday, April 23, 2009, 2:41 AM Dmitry Kislyuk wrote:
Any particular reason for adding these tests? Is there an app depending on the last error?
-- Cheers,
Paul.
Dmitry Kislyuk wrote:
I don't have a particular app for you, however, there can easily be apps that would behave differently from how they would on Windows due to these last errors not being set to what the app expects. Do you have a reason why Wine behavior should not match the Windows behavior in these test cases? By Windows behavior I am referring to the more recent Windows versions of course.
Dmitry
Please bottom-post.
I don't think we want to have last errors set or tested just for the sake of it. I can imagine it makes some sense in a failure case (return value of GetPrivateProfileString being 0?).
Others, please correct me if I'm wrong here.
On Thu, Apr 23, 2009 at 10:06 AM, Paul Vriens paul.vriens.wine@gmail.com wrote:
Dmitry Kislyuk wrote:
I don't have a particular app for you, however, there can easily be apps that would behave differently from how they would on Windows due to these last errors not being set to what the app expects. Do you have a reason why Wine behavior should not match the Windows behavior in these test cases? By Windows behavior I am referring to the more recent Windows versions of course.
My understanding is that the LastError messages vary a bit between windows versions. Wine tries to be compatible with multiple windows versions so deciding which would be the "right" lasterror message to give is the problem that occurs.
--John Klehm
-
Dmitry Kislyuk -
John Klehm -
Paul Vriens