dead stores in netapi32

[ricardo filipe]

hi juan!

i'm tracking some dead stores with Clang and i've found some in files you created that i'm not comfortable messing with.

file dlls/netapi32/nbt.c:
lines:
419
839
1185
1192
1201

file dlls/netapi32/netbios.c:
lines:
634
636

i thought you might want to have a look at it :)
regards,
ricardo
_________________________________________________________________
Cansado de espaço para só 50 fotos? Conheça o Spaces, o site de relacionamentos com até 6,000 fotos!
http://www.amigosdomessenger.com.br

[Kai Blin]

On Tuesday 18 November 2008 23:13:38 ricardo filipe wrote:
> hi juan!
>
> i'm tracking some dead stores with Clang and i've found some in files you
> created that i'm not comfortable messing with.

Does that netbios code actually work? IIRC you need to bind to port 137 to do 
netbios requests. I can see that failing in most use cases, as you shouldn't 
be root when running Wine. And even if you are, it'll fail if you're running 
nmbd from Samba.

Cheers,
Kai

[Juan Lang]

> Does that netbios code actually work? IIRC you need to bind to port 137 to do
> netbios requests.

That's not strictly true, you can be a client without binding to port
137.  You just can't advertise any services.  I haven't tried it
myself in a long, long time, though I did hear from a couple people
that were using it successfully a few years ago.
--Juan

[Kai Blin]

On Wednesday 19 November 2008 00:10:52 Juan Lang wrote:
> > Does that netbios code actually work? IIRC you need to bind to port 137
> > to do netbios requests.
>
> That's not strictly true, you can be a client without binding to port
> 137.  You just can't advertise any services.  I haven't tried it
> myself in a long, long time, though I did hear from a couple people
> that were using it successfully a few years ago.

Oh, ok. I've only ever seen 137 in traces, but I guess that makes sense on 
Windows, where browsing is a system service anyway.

Thanks for pointing that out, Juan.

Ricardo, I'm currently looking at the netapi32 files you pointed out.

Thanks for the catch.

Cheers,
Kai