Re: winmm: Change default driver order to be alsa,coreaudio,oss - try2

[Vitaliy Margolen]

Maarten Lankhorst wrote:
> Forgot to remove the strlen check.

Isn't this a bit premature? ALSA still does not support proper sound 
capture, working mixer, and not stable enough on some configurations.

Vitaliy

winmm: Change default driver order to be alsa,coreaudio,oss - try2

[Maarten Lankhorst]

Vitaliy Margolen schreef:
> Isn't this a bit premature? ALSA still does not support proper sound
> capture, working mixer, and not stable enough on some configurations.

Mixer works properly, as you saw for yourself. Only thing that is
different is just that the alsa accelerated capture code is new and
might contain a few bugs. Apart from that everything is there and
working, unless you have some win3.11 apps that need aux.

Cheers,
Maarten

winmm: Change default driver order to be alsa,coreaudio,oss - try2

[Vitaliy Margolen]

Maarten Lankhorst wrote:
> Vitaliy Margolen schreef:
> > Isn't this a bit premature? ALSA still does not support proper sound
> > capture, working mixer, and not stable enough on some configurations.
>
> Mixer works properly, as you saw for yourself. Only thing that is
> different is just that the alsa accelerated capture code is new and
> might contain a few bugs. Apart from that everything is there and
> working, unless you have some win3.11 apps that need aux.
>
> Cheers,
> Maarten

Yeah I sent an e-mail before finding out which mixer doesn't work. Of course 
MPU401 doesn't have one :-)

I would still suggest to wait for at least one more week before committing 
this patch. Also historically it was a bad idea to select multiple sund 
devices, as all of them require different settings. For example majority of 
users can't use full acceleration with OSS, because in almost all cases it's 
alsa->oss driver on non hw-mixing capable hardware/drivers. While "full" is 
recommended for ALSA to work properly.

Vitaliy.

winmm: Change default driver order to be alsa,coreaudio,oss - try2

[Maarten Lankhorst]

Hi Vitaliy,

Vitaliy Margolen schreef:
> I would still suggest to wait for at least one more week before
> committing this patch. Also historically it was a bad idea to select
> multiple sund devices, as all of them require different settings. For
> example majority of users can't use full acceleration with OSS,
> because in almost all cases it's alsa->oss driver on non hw-mixing
> capable hardware/drivers. While "full" is recommended for ALSA to work
> properly.

To make directsound work in windows, I have committed a bunch of
patches, one of them should make it possible for OSS to work at 'Full'
and still fallback to emulation without crashing, feel free to test it.

By default, no configuration should be needed any more, except to set
rate to 44100 and 16 bit, which is preferred above 22050/8 bit at any time.

Cheers,
Maarten

winmm: Change default driver order to be alsa,coreaudio,oss - try2

[Vitaliy Margolen]

Maarten Lankhorst wrote:
> Hi Vitaliy,
>
> Vitaliy Margolen schreef:
> > I would still suggest to wait for at least one more week before
> > committing this patch. Also historically it was a bad idea to select
> > multiple sund devices, as all of them require different settings. For
> > example majority of users can't use full acceleration with OSS,
> > because in almost all cases it's alsa->oss driver on non hw-mixing
> > capable hardware/drivers. While "full" is recommended for ALSA to work
> > properly.
>
> To make directsound work in windows, I have committed a bunch of
> patches, one of them should make it possible for OSS to work at 'Full'
> and still fallback to emulation without crashing, feel free to test it.
>
> By default, no configuration should be needed any more, except to set
> rate to 44100 and 16 bit, which is preferred above 22050/8 bit at any time.

That didn't work all that well:

err:wave:DSDB_MapBuffer Please run winecfg, open "Audio" page and set
"Hardware Acceleration" to "Emulation".
wine: Unhandled page fault on read access to 0x00000030 at address 
0x7edf2cf8 (thread 0011), starting debugger...

This is with OSS and full acceleration.

winmm: Change default driver order to be alsa,coreaudio,oss - try2

[Maarten Lankhorst]

Vitaliy Margolen schreef:
> That didn't work all that well:
>
> err:wave:DSDB_MapBuffer Please run winecfg, open "Audio" page and set
> "Hardware Acceleration" to "Emulation".
> wine: Unhandled page fault on read access to 0x00000030 at address
> 0x7edf2cf8 (thread 0011), starting debugger...
>
> This is with OSS and full acceleration.

Just sent-in patch to dsound fixes that, even then it is no reason not
to accept this patch as it would have happened already with the current
code.

Cheers,
Maarten

winmm: Change default driver order to be alsa,coreaudio,oss - try2

[Vitaliy Margolen]

Maarten Lankhorst wrote:
> Vitaliy Margolen schreef:
> > That didn't work all that well:
> >
> > err:wave:DSDB_MapBuffer Please run winecfg, open "Audio" page and set
> > "Hardware Acceleration" to "Emulation".
> > wine: Unhandled page fault on read access to 0x00000030 at address
> > 0x7edf2cf8 (thread 0011), starting debugger...
> >
> > This is with OSS and full acceleration.
>
> Just sent-in patch to dsound fixes that, even then it is no reason not
> to accept this patch as it would have happened already with the current
> code.

Doesn't help:
wine: Unhandled page fault on read access to 0x00000030 at address  0x7edfccf8 (thread 0011), starting debugger...
Backtrace:
=>1 0x7edfccf8 waveOutUnprepareHeader+0x38(hWaveOut=0x8000, lpWaveOutHdr=0x20, uSize=0x20) [/usr/local/src/wine.git-build/dlls/winmm/../../../wine.git/dlls/winmm/winmm.c:2289] in winmm (0x00349e28)

Vitaliy.

winmm: Change default driver order to be alsa,coreaudio,oss - try2

[Maarten Lankhorst]

Vitaliy Margolen schreef:
> Maarten Lankhorst wrote:
> > Vitaliy Margolen schreef:
> > > That didn't work all that well:
> > >
> > > err:wave:DSDB_MapBuffer Please run winecfg, open "Audio" page and set
> > > "Hardware Acceleration" to "Emulation".
> > > wine: Unhandled page fault on read access to 0x00000030 at address
> > > 0x7edf2cf8 (thread 0011), starting debugger...
> > >
> > > This is with OSS and full acceleration.
> >
> > Just sent-in patch to dsound fixes that, even then it is no reason not
> > to accept this patch as it would have happened already with the current
> > code.
>
> Doesn't help:

To fix it I need a more usable backtrace then that, one that has all
dsound calls too.

Maarten

winmm: Change default driver order to be alsa,coreaudio,oss - try2

[Vitaliy Margolen]

Maarten Lankhorst wrote:
> Vitaliy Margolen schreef:
> > Maarten Lankhorst wrote:
> > > Vitaliy Margolen schreef:
> > > > That didn't work all that well:
> > > >
> > > > err:wave:DSDB_MapBuffer Please run winecfg, open "Audio" page and set
> > > > "Hardware Acceleration" to "Emulation".
> > > > wine: Unhandled page fault on read access to 0x00000030 at address
> > > > 0x7edf2cf8 (thread 0011), starting debugger...
> > > >
> > > > This is with OSS and full acceleration.
> > >
> > > Just sent-in patch to dsound fixes that, even then it is no reason not
> > > to accept this patch as it would have happened already with the current
> > > code.
> >
> > Doesn't help:
>
> To fix it I need a more usable backtrace then that, one that has all
> dsound calls too.

Attached to the bug http://bugs.winehq.org/show_bug.cgi?id=9381

Vitaliy.