Re: [PATCH] Wine's ChangeDisplaySettingsEx is too strict

[Jeff Latimer]

Szombathelyi György wrote:
>  if ((devmode->dmFields & (DM_PELSWIDTH | DM_PELSHEIGHT)) != (DM_PELSWIDTH | DM_PELSHEIGHT))
>  {
>      WARN("devmode doesn't specify the resolution: %04x\n", devmode->dmFields);
> -
>    return DISP_CHANGE_BADMODE;
> }

Is this warning still valid if this is valid Windows behaviour?

Jeff

[PATCH] Wine's ChangeDisplaySettingsEx is too strict

[Dmitry Timoshkov]

"Jeff Latimer"  wrote:
> >  if ((devmode->dmFields & (DM_PELSWIDTH | DM_PELSHEIGHT)) != (DM_PELSWIDTH | DM_PELSHEIGHT))
> >  {
> >      WARN("devmode doesn't specify the resolution: %04x\n", devmode->dmFields);
> > -
> >    return DISP_CHANGE_BADMODE;
> > }
>
> Is this warning still valid if this is valid Windows behaviour?

Yes it's still valid until there is a test case which shows that Windows
does something different in this case.