Re: [PATCH 3/6] wined3d: Handle raw thread group shared memory declarations.

[Sebastian Lackner]

On 28.02.2017 14:42, Józef Kucia wrote:
> -
>            reg_maps->tgsm_count = reg_idx + 1;

Wouldn't it be better to set it to max(reg_maps->tgsm_count, ...) to
allow decreasing reg indices (even if not seen in practice yet)?
Alternatively you could also get rid of this variable and update patch
6 to check the index against the capacity.

Best regards,
Sebastian

[PATCH 3/6] wined3d: Handle raw thread group shared memory declarations.

[Józef Kucia]

On Wed, Mar 1, 2017 at 5:49 PM, Sebastian Lackner  wrote:
> On 28.02.2017 14:42, Józef Kucia wrote:
> > -
> >            reg_maps->tgsm_count = reg_idx + 1;
>
> Wouldn't it be better to set it to max(reg_maps->tgsm_count, ...) to
> allow decreasing reg indices (even if not seen in practice yet)?
> Alternatively you could also get rid of this variable and update patch
> 6 to check the index against the capacity.

Yes, it would be better, but I think it doesn't matter in practice.