Hi Alistair,
Alistair Leslie-Hughes leslie_alistair@hotmail.com wrote:
Based off Dmitry Timoshkov patch.
It's an exact copy of my patch with just one hunk removed (without which the tests won't pass under Wine). So it's not just "based", it's a plain copy. It would be fine if you sent it in two parts: first under my name (but in that case you need at least my sign-off), and next patch with your test case.
Dmitry Timoshkov dmitry@baikal.ru wrote:
Alistair Leslie-Hughes leslie_alistair@hotmail.com wrote:
Based off Dmitry Timoshkov patch.
It's an exact copy of my patch with just one hunk removed (without which the tests won't pass under Wine). So it's not just "based", it's a plain copy. It would be fine if you sent it in two parts: first under my name (but in that case you need at least my sign-off), and next patch with your test case.
Actually it's perfectly fine if you send the patch without my sign-off, just in that case you take full resposibility for the possible regressions (but in that case the regression keyword in bugzilla will lead to incorrect responsible person assigned on the regressions page stats, the regression script has to be updated to work correctly with the sign-off mechanism).
-
Dmitry Timoshkov