Re: gdi: Fix meaning and use of bidirectionality flags

[Shachar Shemesh]

Maarten Lankhorst wrote:
> According to shachar shamesh they have a slightly different meaning.
> This should fix it.

First of all, things seem much much better with this patch.

I would direct your attention to the fact that, when I run it, I get:
> $ programs/notepad/notepad
> fixme:bidi:mirror stub: mirroring of characters not yet implemented
> fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN
> fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5
> fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5
> fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN
> fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN
> fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5
> fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5
> fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5
> fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5
> fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN
> fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN
> fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN
> fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN
> fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN
> fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN
> fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN
> fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN
> fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5
> fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5
> fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5
> fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5
> fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5
> fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5
> fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5
> fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5
> fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5
> fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5
> fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5
> fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5
> fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5
> fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5
> fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5
> fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5

As far as I can tell, an assert should not be a "fixme", but that's
something else.

Shachar