cvs woes

[Ann and Jason Edmeades]

| device.c: In function `IDirect3DDevice8Impl_SetTextureStageState':
| device.c:3456: `GL_MIRRORED_REPEAT_ARB' undeclared (first use in this
function)
| device.c:3456: (Each undeclared identifier is reported only once
| device.c:3456: for each function it appears in.)

Hmm - This is a more tricky one to fix - Lionel, got any ideas?

I have #if'defed it for GL_VERSION_1_3, but it looks like some headers who
define GL_VERSION_1_3 dont have the mirrored repeat ARB defines.

As a workaround, add #define GL_MIRRORED_REPEAT_ARB 0x8370 at the top of the
source part.

Question - If you look in your glext.h, does it define GL_MIRRORED_REPEAT
instead?

Jason

[Lionel Ulmer]

> Hmm - This is a more tricky one to fix - Lionel, got any ideas?

Not really, except that its not defined either on my box but I have
'GL_MIRRORED_REPEAT_IBM' which seems to be more common.

I think instead of testing on OpenGL 1.3 for extensions, one should rather
test on all individual defines which are used in glext.h (for example, in
this case 'GL_ARB_texture_mirrored_repeat').

Lionel

[Ann and Jason Edmeades]

Looking at the XFree/mesa headers, it implies MIRROR_REPEAT is in gl 1.4, so
I will try a joint approach of

switch (Value) {
            case D3DTADDRESS_WRAP:   wrapParm = GL_REPEAT; break;
            case D3DTADDRESS_CLAMP:  wrapParm = GL_CLAMP_TO_EDGE; break;
            case D3DTADDRESS_BORDER: wrapParm = GL_REPEAT; break;      /*
FIXME: Not right, but better */
#if defined(GL_VERSION_1_4)
            case D3DTADDRESS_MIRROR: wrapParm = GL_MIRRORED_REPEAT; break;
            case D3DTADDRESS_MIRRORONCE:  /* Unsupported in OpenGL but
pretent mirror */
#elif defined(GL_ARB_texture_mirrored_repeat)
            case D3DTADDRESS_MIRROR: wrapParm = GL_MIRRORED_REPEAT_ARB;
break;
            case D3DTADDRESS_MIRRORONCE:  /* Unsupported in OpenGL but
pretent mirror */
#else
            case D3DTADDRESS_MIRROR:      /* Unsupported in OpenGL pre-1.4
*/
            case D3DTADDRESS_MIRRORONCE:  /* Unsupported in OpenGL
*/
#endif
            default:

Would this work for the people failing? If so I'll submit it

I wouldnt have thought simple changes like those 2 patches could have broken
so much!! Sorry about that

However, I am happy as with 2 unsubmitted changes, I can now see some of
WC3's menus :-) Shame I am developing on a un-accelerated system, so a frame
rate of 1 every about 10 seconds is slightly slow.....

Regards,
Jason

-----Original Message-----
From: Lionel Ulmer [mailto:[e-mail]]
Sent: 20 April 2003 15:26
To: Ann and Jason Edmeades
Cc: wine devel; [e-mail]
Subject: Re: cvs woes
> Hmm - This is a more tricky one to fix - Lionel, got any ideas?

Not really, except that its not defined either on my box but I have
'GL_MIRRORED_REPEAT_IBM' which seems to be more common.

I think instead of testing on OpenGL 1.3 for extensions, one should rather
test on all individual defines which are used in glext.h (for example, in
this case 'GL_ARB_texture_mirrored_repeat').

Lionel

--
    	 Lionel Ulmer - http://www.bbrox.org/

[Rein Klazes]

On Sun, 20 Apr 2003 14:47:33 +0100, you wrote:
> | device.c: In function `IDirect3DDevice8Impl_SetTextureStageState':
> | device.c:3456: `GL_MIRRORED_REPEAT_ARB' undeclared (first use in this
> function)
> | device.c:3456: (Each undeclared identifier is reported only once
> | device.c:3456: for each function it appears in.)
>
> Hmm - This is a more tricky one to fix - Lionel, got any ideas?
>
> I have #if'defed it for GL_VERSION_1_3, but it looks like some headers who
> define GL_VERSION_1_3 dont have the mirrored repeat ARB defines.
>
> As a workaround, add #define GL_MIRRORED_REPEAT_ARB 0x8370 at the top of the
> source part.

Yes that compiles.
> Question - If you look in your glext.h, does it define GL_MIRRORED_REPEAT
> instead?

It does not.

Rein.