re: crypt32: Fix Quote-Handling (try 2)

[Juan Lang]

Hi Christian,
on second thought I don't have too much to say about this, other than
style comments:  take them or leave them.

+/* Only use this function internally. */
This comment isn't all that useful.  You might indicate that quotes
are only needed by CertNameToStr when the string type is
CERT_X500_NAME_STR, but that might be clear enough from the code.
Also, since CertRDNValueToStr doesn't need quote_string, you should
probably invert the order in which they appear in the file.

Thanks,
--Juan

crypt32: Fix Quote-Handling (try 2)

[Christian Inci]

Am 2011-01-11 17:11, schrieb Juan Lang:
> Also, since CertRDNValueToStr doesn't need quote_string, you should
> probably invert the order in which they appear in the file.

The calls or the definitions?
If the definition, should I move is_quotable_char too?
--Christian

crypt32: Fix Quote-Handling (try 2)

[Juan Lang]

> The calls or the definitions?
> If the definition, should I move is_quotable_char too?

The definitions.  Yes, please.
--Juan