RFC: patch 105133

[Jérôme Gardou]

Hello wine team.

According to the patch status page, the following patch is still marked 
as "new".
http://source.winehq.org/patches/data/105133
Is there any prioritisation for the testbot regarding the jobs it 
processes ?

Also, that put aside, I'd like to discuss the approach and the problem 
there as I understand it: with "modern" stubs, allocations and frees are 
made per argument. If there is no prioritisation on how this is done, 
the "freeer" of one argument can rely on data which were freed before in 
the loop and overwritten, thus causing the mayhem in the heap that can 
be witnessed here (see https://bugs.winehq.org/show_bug.cgi?id=36743).

The patch tries to overcome the problem and frees the arguments marked 
as "MustFree" before anything else. I believe this is the right 
approach, but a comment from someone more proficient as me in RPC 
matters would be greatly appreciated.

Regards
Jérôme

[Henri Verbeet]

On 30 June 2014 16:01, Jérôme Gardou  wrote:
> According to the patch status page, the following patch is still marked as
> "new".
> http://source.winehq.org/patches/data/105133
> Is there any prioritisation for the testbot regarding the jobs it processes
> ?

There is, but since that patch doesn't touch the tests the testbot is
not really involved.

[Jérôme Gardou]

Le 30.06.2014 16:06, Henri Verbeet a écrit :
> On 30 June 2014 16:01, Jérôme Gardou  wrote:
> > According to the patch status page, the following patch is still marked as
> > "new".
> > http://source.winehq.org/patches/data/105133
> > Is there any prioritisation for the testbot regarding the jobs it processes
> > ?
>
> There is, but since that patch doesn't touch the tests the testbot is
> not really involved.

Oh... I thought it at least tried to apply the patch and run the test 
suite with the patched wine binary.

[Henri Verbeet]

On 30 June 2014 16:12, Jérôme Gardou  wrote:
> Oh... I thought it at least tried to apply the patch and run the test suite
> with the patched wine binary.

We'd like that in the future, but currently it only runs the tests on Windows.