Re: msi: Added MsiInstallMissingComponentW stub implementation.

[Kai Blin]

On Monday 06 October 2008 23:05:25 Jacek Caban wrote:
> +UINT WINAPI MsiInstallMissingComponentW(LPCWSTR szProduct, LPCWSTR

...
> 83 stub MsiInstallMissingComponentA
> -84 stub MsiInstallMissingComponentW
> +84 stdcall MsiInstallMissingComponentW(wstr wstr long)

...
> diff --git a/include/msi.h b/include/msi.h
> index 20dca3a..cf125ef 100644
> --- a/include/msi.h
> +++ b/include/msi.h
> @@ -603,6 +603,10 @@ UINT WINAPI MsiDatabaseMergeA(MSIHANDLE, MSIHANDLE,
> LPCSTR); UINT WINAPI MsiDatabaseMergeW(MSIHANDLE, MSIHANDLE, LPCWSTR);
>  #define     MsiDatabaseMerge WINELIB_NAME_AW(MsiDatabaseMerge)
>  
> +UINT WINAPI MsiInstallMissingComponentA(LPCSTR, LPCSTR, INSTALLSTATE);
> +UINT WINAPI MsiInstallMissingComponentW(LPCWSTR, LPCWSTR, INSTALLSTATE);
> +#define     MsiInstallMissingComponent WINELIB_NAME_AW(MsiInstallMissingComponent) +

Isn't this going to break if an app is trying to use Ansi MsiInstallMissingComponent?

Cheers,
Kai

msi: Added MsiInstallMissingComponentW stub implementation.

[Jacek Caban]

Kai Blin wrote:
> On Monday 06 October 2008 23:05:25 Jacek Caban wrote:
> > +UINT WINAPI MsiInstallMissingComponentW(LPCWSTR szProduct, LPCWSTR
>
> ...
> > 83 stub MsiInstallMissingComponentA
> > -84 stub MsiInstallMissingComponentW
> > +84 stdcall MsiInstallMissingComponentW(wstr wstr long)
>
> ...
> > diff --git a/include/msi.h b/include/msi.h
> > index 20dca3a..cf125ef 100644
> > --- a/include/msi.h
> > +++ b/include/msi.h
> > @@ -603,6 +603,10 @@ UINT WINAPI MsiDatabaseMergeA(MSIHANDLE, MSIHANDLE,
> > LPCSTR); UINT WINAPI MsiDatabaseMergeW(MSIHANDLE, MSIHANDLE, LPCWSTR);
> >  #define     MsiDatabaseMerge WINELIB_NAME_AW(MsiDatabaseMerge)
> >
> > +UINT WINAPI MsiInstallMissingComponentA(LPCSTR, LPCSTR, INSTALLSTATE);
> > +UINT WINAPI MsiInstallMissingComponentW(LPCWSTR, LPCWSTR, INSTALLSTATE);
> > +#define     MsiInstallMissingComponent WINELIB_NAME_AW(MsiInstallMissingComponent) +
>
> Isn't this going to break if an app is trying to use Ansi MsiInstallMissingComponent?

How could it? I don't touch ASCII version, so it won't be worse than it 
was before my patch. I've only added its declaration to header file.

Jacek