Hi All,
I just submitted my first ever patch to wine-patches (attached) - good news. In retrospect I may have been a little premature. The patch adds tests for user32:DrawIcon and user32:DrawIconEx including tests for icon alpha blending which wine does not currently support.
It occured to me that my alpha tests will fail in versions of Windows that don't support alpha blending - but the problem is I'm not sure at what point alpha began to be supported. I only have a VM for XP - and I think, but I don't know for sure, that alpha icons began to be supported in 2000.
How do you deal with this problem, because presumably not every test contributor has VMs ready to confirm the behaviour of 95, 98, ME, 2000, XP and Vista. Do I submit the patch as-is, in the knowlege that it will cause failures in old windows? Presumably not - so what do you suggest I do?
I now have code to make DrawIcon pass the alpha tests, and I'm hoping to have DrawIconEx ready in a few hours. With these done it should be possible to in-cooperate my Tango patches, which should improve the appearance of wine quite substantially.
Thanks Joel
Hi Joel,
How do you deal with this problem, because presumably not every test contributor has VMs ready to confirm the behaviour of 95, 98, ME, 2000, XP and Vista. Do I submit the patch as-is, in the knowlege that it will cause failures in old windows? Presumably not - so what do you suggest I do?
That's what we generally end up doing. Watching test.winehq.org for test results once a patch gets committed, or waiting for an email from someone who watches the results, is a way to get feedback on test failures on other platforms.
The alternative is to ask someone to test your tests on other platforms, by asking on wine-devel as you've done.
Cheers, --Juan
On Sat, 2009-05-02 at 08:58 -0700, Juan Lang wrote:
Hi Joel,
How do you deal with this problem, because presumably not every test contributor has VMs ready to confirm the behaviour of 95, 98, ME, 2000, XP and Vista. Do I submit the patch as-is, in the knowlege that it will cause failures in old windows? Presumably not - so what do you suggest I do?
That's what we generally end up doing. Watching test.winehq.org for test results once a patch gets committed, or waiting for an email from someone who watches the results, is a way to get feedback on test failures on other platforms.
The alternative is to ask someone to test your tests on other platforms, by asking on wine-devel as you've done.
Cheers, --Juan
Ahh ok that's good news!
-
Joel Holdsworth -
Juan Lang