Re: [PATCH v2] msvcp100: Add stub for Concurrency::is_current_task_group_canceling

[Piotr Caban]

Hi,

Is any application working thanks to this patch (not crashing on next 
unimplemented function)?

Thanks,
Piotr

[PATCH v2] msvcp100: Add stub for Concurrency::is_current_task_group_canceling

[Gijs Vermeulen]

Hi,

I made this for bug 34676 (Gas Guzzlers Combat Carnage Demo).
It was confirmed that the patch helped, but I'm not sure if it crashed on
something else or if it worked.
I'll try and test this.

Sincerely,
Gijs

2017-03-21 12:38 GMT+01:00 Piotr Caban :
> Hi,
>
> Is any application working thanks to this patch (not crashing on next
> unimplemented function)?
>
> Thanks,
> Piotr

[PATCH v2] msvcp100: Add stub for Concurrency::is_current_task_group_canceling

[Piotr Caban]

Hi,

On 03/21/17 14:40, Gijs Vermeulen wrote:
> I made this for bug 34676 (Gas Guzzlers Combat Carnage Demo).
> It was confirmed that the patch helped, but I'm not sure if it crashed
> on something else or if it worked.
> I'll try and test this.

Andrey let me know that the app works for him with your patch. Because 
of that I'm OK with having the stub in wine (I'm currently working on 
proper implementation but it might take a while).

Your patch is no longer applying cleanly. Could you please update it?

Thanks,
Piotr

[PATCH v2] msvcp100: Add stub for Concurrency::is_current_task_group_canceling

[Gijs Vermeulen]

Hi,

I have sent an updated version.
Thank you for the review.

Sincerely,
Gijs

2017-03-22 9:32 GMT+01:00 Piotr Caban :
> Hi,
>
> On 03/21/17 14:40, Gijs Vermeulen wrote:
> > I made this for bug 34676 (Gas Guzzlers Combat Carnage Demo).
> > It was confirmed that the patch helped, but I'm not sure if it crashed
> > on something else or if it worked.
> > I'll try and test this.
>
> Andrey let me know that the app works for him with your patch. Because of
> that I'm OK with having the stub in wine (I'm currently working on proper
> implementation but it might take a while).
>
> Your patch is no longer applying cleanly. Could you please update it?
>
> Thanks,
> Piotr