-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
Am 2015-10-15 um 21:54 schrieb Bernhard Übelacker:
hr = IDirect3DRM3_CreateDeviceFromClipper(d3drm, pClipper, &driver, rc.right, rc.bottom, &device); ok(hr == D3DRM_OK, "Cannot get IDirect3DRMDevice interface (hr = %x)\n", hr);
- if (FAILED(hr))
- {
skip("Cannot get IDirect3DRMDevice interface (hr = %x), skipping tests\n", hr);IDirectDrawClipper_Release(pClipper);IDirect3DRM_Release(d3drm);DestroyWindow(window);return;- }
The test will fail regardless, so you don't gain too much. It would be nicer if the test skips without a failing ok() statement in this case.
Do you have a Windows VM to test how native d3drm responds if d3d is not available? I.e., which error code is returned? It might be a bit tricky to test because we request a software device that Wine doesn't implement but should be available everywhere on Windows. If you need help finding that out I can play a bit with my Windows XP box.
(Technically failing is correct because we should have a software device without host GL in theory, but I don't expect that we'll ever implement one, so I think not failing the test if GL isn't available is the best thing to do)
On 16 October 2015 at 13:16, Stefan Dösinger stefandoesinger@gmail.com wrote:
(Technically failing is correct because we should have a software device without host GL in theory, but I don't expect that we'll ever implement one, so I think not failing the test if GL isn't available is the best thing to do)
You could always use something like Mesa softpipe or llvmpipe for OpenGL. This is a configuration issue, IMO.
Am 16.10.2015 um 13:16 schrieb Stefan Dösinger:
The test will fail regardless, so you don't gain too much. It would be nicer if the test skips without a failing ok() statement in this case.
Do you have a Windows VM to test how native d3drm responds if d3d is not available? I.e., which error code is returned? It might be a bit tricky to test because we request a software device that Wine doesn't implement but should be available everywhere on Windows. If you need help finding that out I can play a bit with my Windows XP box.
(Technically failing is correct because we should have a software device without host GL in theory, but I don't expect that we'll ever implement one, so I think not failing the test if GL isn't available is the best thing to do)
Am 16.10.2015 um 13:33 schrieb Henri Verbeet:
On 16 October 2015 at 13:16, Stefan Dösinger stefandoesinger@gmail.com wrote:
(Technically failing is correct because we should have a software device without host GL in theory, but I don't expect that we'll ever implement one, so I think not failing the test if GL isn't available is the best thing to do)
You could always use something like Mesa softpipe or llvmpipe for OpenGL. This is a configuration issue, IMO.
Thanks for your answers.
My intent was just to avoid the test crashing when it accesses the not created device. Therefore the skip is after the failing ok() statement.
And having no GL in Xephyr seems to be caused by using the nvidia proprietary driver. Adjusting LD_LIBRARY_PATH to get Xephyr load the mesa supplied libGL makes GL(llvmpipe) available inside and the tests do not crash.
Is there desire to get tests at least not crash in such rare conditions?
Kind regards, Bernhard
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
Am 2015-10-16 um 15:03 schrieb Bernhard Übelacker:
Is there desire to get tests at least not crash in such rare conditions?
In theory there's no difference between a crash and a failure. In both cases the run is considered a failure.
You get a crash dialog, but you can disable that.
Am 16.10.2015 um 15:11 schrieb Stefan Dösinger:
Am 2015-10-16 um 15:03 schrieb Bernhard Übelacker:
Is there desire to get tests at least not crash in such rare conditions?
In theory there's no difference between a crash and a failure. In both cases the run is considered a failure.
You get a crash dialog, but you can disable that.
Ok, you mean something like this (just for the record): wine reg add HKCU\Software\Wine\WineDbg /v ShowCrashDialog /t REG_DWORD /d 0
Thanks for your time.
Kind regards, Bernhard
-
Bernhard Übelacker -
Henri Verbeet -
Stefan Dösinger