On Do, Aug 15, 2019 at 3:17 AM, Marvin testbot@winehq.org wrote:
Thank you for your contribution to Wine!
This is an automated notification to let you know that your patch has been reviewed and its status set to "Committed".
This means that your patch has been approved, and committed to the main git tree. Congratulations!
Commit: https://source.winehq.org/git/wine.git/commit/a20295ce3ddde224f9d958f6a4e5d1...
Hi Piotr,
Sorry for the late response - I had quite busy days.
After looking at the commit in wine master, I noticed some of the functions of the patch didn't make it, namely:
_o__wsetlocale _o_atoi _o_ceil _o_floor
Both in api-ms-win-crt-private-l1-1-0 and ucrtbase. This gets the game to crash with "wine: Call from 0x7b462ff5 to unimplemented function api-ms-win-crt-private-l1-1-0.dll._o_floor, aborting"
Is there a reason these got ommited?
I'm happy to send these in a new patch again if needed.
Many thanks, Benedikt
Hi Benedikt,
After looking at the commit in wine master, I noticed some of the functions of the patch didn't make it, namely:
_o__wsetlocale _o_atoi _o_ceil _o_floor
You didn’t send changes for these functions to ucrtbase spec file. Forwards to stubs are removed by make_specfiles script, I guess this is why it was removed from the api-ms-win-crt-private-l1-1-0 spec file.
Please send a new patch that contains changes for these functions.
Thanks, Piotr
You didn’t send changes for these functions to ucrtbase spec file. Forwards to stubs are removed by make_specfiles script, I guess this is why it was removed from the api-ms-win-crt-private-l1-1-0 spec file.
Ah, indeed looking at my git checkout, I forgot to stage the last changes before committing. Makes sense that forwards to stubs would be removed by the script, thanks for clarifying.
Will send a patch for the missing functions shortly.
Cheers, Benedikt
-
Benedikt Bär | Relamp.tk -
beniwtv＠relamp.tk
-
Piotr Caban