Re: [1/7] ntdll/tests: Use longer waits to reduce risk of random failures on the testbot.
Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25284
Your paranoid android.
=== w7u (32 bit threadpool) === threadpool.c:367: Test failed: WaitForSingleObject returned 258 threadpool.c:379: Test failed: expected info.userdata = 0x10000, got 0 threadpool.c:390: Test failed: expected info.userdata = 0x10000, got 0 threadpool.c:409: Test failed: expected info.userdata = 1, got 0 threadpool.c:422: Test failed: expected info.userdata = 1, got 0 threadpool.c:424: Test failed: expected STATUS_PENDING, got 0 threadpool.c:427: Test failed: WaitForSingleObject returned 258
=== w864 (64 bit threadpool) === threadpool.c:1618: Test failed: WaitForSingleObject returned 258 threadpool.c:1619: Test failed: expected result 2, got 0 threadpool.c:1619: Test failed: expected result 4, got 2 threadpool.c:1619: Test failed: expected result 6, got 4 threadpool.c:1619: Test failed: expected result 8, got 6 threadpool.c:1619: Test failed: expected result 10, got 8 threadpool.c:1619: Test failed: expected result 12, got 10 threadpool.c:1619: Test failed: expected result 14, got 12 threadpool.c:1619: Test failed: expected result 16, got 14 threadpool.c:1619: Test failed: expected result 18, got 16 threadpool.c:1619: Test failed: expected result 20, got 18 threadpool.c:1619: Test failed: expected result 22, got 20 threadpool.c:1619: Test failed: expected result 24, got 22 threadpool.c:1619: Test failed: expected result 26, got 24 threadpool.c:1619: Test failed: expected result 28, got 26 threadpool.c:1619: Test failed: expected result 30, got 28 threadpool.c:1619: Test failed: expected result 32, got 30 threadpool.c:1619: Test failed: expected result 34, got 32 threadpool.c:1619: Test failed: expected result 36, got 34 threadpool.c:1619: Test failed: expected result 38, got 36 threadpool.c:1619: Test failed: expected result 40, got 38 threadpool.c:1619: Test failed: expected result 42, got 40 threadpool.c:1619: Test failed: expected result 44, got 42 threadpool.c:1619: Test failed: expected result 46, got 44 threadpool.c:1619: Test failed: expected result 48, got 46 threadpool.c:1619: Test failed: expected result 50, got 48 threadpool.c:1619: Test failed: expected result 52, got 50 threadpool.c:1619: Test failed: expected result 54, got 52 threadpool.c:1619: Test failed: expected result 56, got 54 threadpool.c:1619: Test failed: expected result 58, got 56 threadpool.c:1619: Test failed: expected result 60, got 58 threadpool.c:1619: Test failed: expected result 62, got 60 threadpool.c:1619: Test failed: expected result 64, got 62 threadpool.c:1619: Test failed: expected result 66, got 64 threadpool.c:1619: Test failed: expected result 68, got 66 threadpool.c:1619: Test failed: expected result 70, got 68 threadpool.c:1619: Test failed: expected result 72, got 70 threadpool.c:1619: Test failed: expected result 74, got 72 threadpool.c:1619: Test failed: expected result 76, got 74 threadpool.c:1619: Test failed: expected result 78, got 76 threadpool.c:1619: Test failed: expected result 80, got 78 threadpool.c:1619: Test failed: expected result 82, got 80 threadpool.c:1619: Test failed: expected result 84, got 82 threadpool.c:1619: Test failed: expected result 86, got 84 threadpool.c:1619: Test failed: expected result 88, got 86 threadpool.c:1619: Test failed: expected result 90, got 88 threadpool.c:1619: Test failed: expected result 92, got 90 threadpool.c:1619: Test failed: expected result 94, got 92 threadpool.c:1619: Test failed: expected result 96, got 94 threadpool.c:1619: Test failed: expected result 98, got 96 threadpool.c:1619: Test failed: expected result 100, got 98 threadpool.c:1619: Test failed: expected result 102, got 100 threadpool.c:1619: Test failed: expected result 104, got 102 threadpool.c:1619: Test failed: expected result 106, got 104 threadpool.c:1619: Test failed: expected result 108, got 106 threadpool.c:1619: Test failed: expected result 110, got 108 threadpool.c:1619: Test failed: expected result 112, got 110 threadpool.c:1619: Test failed: expected result 114, got 112 threadpool.c:1619: Test failed: expected result 116, got 114 threadpool.c:1619: Test failed: expected result 118, got 116 threadpool.c:1619: Test failed: expected result 120, got 118 threadpool.c:1619: Test failed: expected result 122, got 120 threadpool.c:1619: Test failed: expected result 124, got 122 threadpool.c:1619: Test failed: expected result 126, got 124 threadpool.c:1619: Test failed: expected result 128, got 126 threadpool.c:1619: Test failed: expected result 130, got 128 threadpool.c:1619: Test failed: expected result 132, got 130 threadpool.c:1619: Test failed: expected result 134, got 132 threadpool.c:1619: Test failed: expected result 136, got 134 threadpool.c:1619: Test failed: expected result 138, got 136 threadpool.c:1619: Test failed: expected result 140, got 138 threadpool.c:1619: Test failed: expected result 142, got 140 threadpool.c:1619: Test failed: expected result 144, got 142 threadpool.c:1619: Test failed: expected result 146, got 144 threadpool.c:1619: Test failed: expected result 148, got 146 threadpool.c:1619: Test failed: expected result 150, got 148 threadpool.c:1619: Test failed: expected result 152, got 150 threadpool.c:1619: Test failed: expected result 154, got 152 threadpool.c:1619: Test failed: expected result 156, got 154 threadpool.c:1619: Test failed: expected result 158, got 156 threadpool.c:1619: Test failed: expected result 160, got 158 threadpool.c:1619: Test failed: expected result 162, got 160 threadpool.c:1619: Test failed: expected result 164, got 162 threadpool.c:1619: Test failed: expected result 166, got 164 threadpool.c:1619: Test failed: expected result 168, got 166 threadpool.c:1619: Test failed: expected result 170, got 168 threadpool.c:1619: Test failed: expected result 172, got 170 threadpool.c:1619: Test failed: expected result 174, got 172 threadpool.c:1619: Test failed: expected result 176, got 174 threadpool.c:1619: Test failed: expected result 178, got 176 threadpool.c:1619: Test failed: expected result 180, got 178 threadpool.c:1619: Test failed: expected result 182, got 180 threadpool.c:1619: Test failed: expected result 184, got 182 threadpool.c:1619: Test failed: expected result 186, got 184 threadpool.c:1619: Test failed: expected result 188, got 186 threadpool.c:1619: Test failed: expected result 190, got 188 threadpool.c:1619: Test failed: expected result 192, got 190 threadpool.c:1619: Test failed: expected result 194, got 192 threadpool.c:1619: Test failed: expected result 196, got 194 threadpool.c:1619: Test failed: expected result 198, got 196 threadpool.c:1619: Test failed: expected result 200, got 198 threadpool.c:1619: Test failed: expected result 202, got 200 threadpool.c:1619: Test failed: expected result 204, got 202 threadpool.c:1619: Test failed: expected result 206, got 204 threadpool.c:1619: Test failed: expected result 208, got 206 threadpool.c:1619: Test failed: expected result 210, got 208 threadpool.c:1619: Test failed: expected result 212, got 210 threadpool.c:1619: Test failed: expected result 214, got 212 threadpool.c:1619: Test failed: expected result 216, got 214 threadpool.c:1619: Test failed: expected result 218, got 216 threadpool.c:1619: Test failed: expected result 220, got 218 threadpool.c:1619: Test failed: expected result 222, got 220 threadpool.c:1619: Test failed: expected result 224, got 222 threadpool.c:1619: Test failed: expected result 226, got 224 threadpool.c:1619: Test failed: expected result 228, got 226 threadpool.c:1619: Test failed: expected result 230, got 228 threadpool.c:1619: Test failed: expected result 232, got 230 threadpool.c:1619: Test failed: expected result 234, got 232 threadpool.c:1619: Test failed: expected result 236, got 234 threadpool.c:1619: Test failed: expected result 238, got 236 threadpool.c:1619: Test failed: expected result 240, got 238 threadpool.c:1619: Test failed: expected result 242, got 240 threadpool.c:1619: Test failed: expected result 244, got 242 threadpool.c:1619: Test failed: expected result 246, got 244 threadpool.c:1619: Test failed: expected result 248, got 246 threadpool.c:1619: Test failed: expected result 250, got 248 threadpool.c:1619: Test failed: expected result 252, got 250 threadpool.c:1619: Test failed: expected result 254, got 252 threadpool.c:1619: Test failed: expected result 256, got 254 threadpool.c:1619: Test failed: expected result 258, got 256 threadpool.c:1619: Test failed: expected result 260, got 258 threadpool.c:1619: Test failed: expected result 262, got 260 threadpool.c:1619: Test failed: expected result 264, got 262 threadpool.c:1619: Test failed: expected result 266, got 264 threadpool.c:1619: Test failed: expected result 268, got 266 threadpool.c:1619: Test failed: expected result 270, got 268 threadpool.c:1619: Test failed: expected result 272, got 270 threadpool.c:1619: Test failed: expected result 274, got 272 threadpool.c:1619: Test failed: expected result 276, got 274 threadpool.c:1619: Test failed: expected result 278, got 276 threadpool.c:1619: Test failed: expected result 280, got 278 threadpool.c:1619: Test failed: expected result 282, got 280 threadpool.c:1619: Test failed: expected result 284, got 282 threadpool.c:1619: Test failed: expected result 286, got 284 threadpool.c:1619: Test failed: expected result 288, got 286 threadpool.c:1619: Test failed: expected result 290, got 288 threadpool.c:1619: Test failed: expected result 292, got 290 threadpool.c:1619: Test failed: expected result 294, got 292 threadpool.c:1619: Test failed: expected result 296, got 294 threadpool.c:1619: Test failed: expected result 298, got 296 threadpool.c:1619: Test failed: expected result 300, got 298 threadpool.c:1619: Test failed: expected result 302, got 300 threadpool.c:1619: Test failed: expected result 304, got 302 threadpool.c:1619: Test failed: expected result 306, got 304 threadpool.c:1619: Test failed: expected result 308, got 306 threadpool.c:1619: Test failed: expected result 310, got 308 threadpool.c:1619: Test failed: expected result 312, got 310 threadpool.c:1619: Test failed: expected result 314, got 312 threadpool.c:1619: Test failed: expected result 316, got 314 threadpool.c:1619: Test failed: expected result 318, got 316 threadpool.c:1619: Test failed: expected result 320, got 318 threadpool.c:1619: Test failed: expected result 322, got 320 threadpool.c:1619: Test failed: expected result 324, got 322 threadpool.c:1619: Test failed: expected result 326, got 324 threadpool.c:1619: Test failed: expected result 328, got 326 threadpool.c:1619: Test failed: expected result 330, got 328 threadpool.c:1619: Test failed: expected result 332, got 330 threadpool.c:1619: Test failed: expected result 334, got 332 threadpool.c:1619: Test failed: expected result 336, got 334 threadpool.c:1619: Test failed: expected result 338, got 336 threadpool.c:1619: Test failed: expected result 340, got 338 threadpool.c:1619: Test failed: expected result 342, got 340 threadpool.c:1619: Test failed: expected result 344, got 342 threadpool.c:1619: Test failed: expected result 346, got 344 threadpool.c:1619: Test failed: expected result 348, got 346 threadpool.c:1619: Test failed: expected result 350, got 348 threadpool.c:1619: Test failed: expected result 352, got 350 threadpool.c:1619: Test failed: expected result 354, got 352 threadpool.c:1619: Test failed: expected result 356, got 354 threadpool.c:1619: Test failed: expected result 358, got 356 threadpool.c:1619: Test failed: expected result 360, got 358 threadpool.c:1619: Test failed: expected result 362, got 360 threadpool.c:1619: Test failed: expected result 364, got 362 threadpool.c:1619: Test failed: expected result 366, got 364 threadpool.c:1619: Test failed: expected result 368, got 366 threadpool.c:1619: Test failed: expected result 370, got 368 threadpool.c:1619: Test failed: expected result 372, got 370 threadpool.c:1619: Test failed: expected result 374, got 372 threadpool.c:1619: Test failed: expected result 376, got 374 threadpool.c:1619: Test failed: expected result 378, got 376 threadpool.c:1619: Test failed: expected result 380, got 378 threadpool.c:1619: Test failed: expected result 382, got 380 threadpool.c:1619: Test failed: expected result 384, got 382 threadpool.c:1619: Test failed: expected result 386, got 384 threadpool.c:1619: Test failed: expected result 388, got 386 threadpool.c:1619: Test failed: expected result 390, got 388 threadpool.c:1619: Test failed: expected result 392, got 390 threadpool.c:1619: Test failed: expected result 394, got 392 threadpool.c:1619: Test failed: expected result 396, got 394 threadpool.c:1619: Test failed: expected result 398, got 396 threadpool.c:1619: Test failed: expected result 400, got 398 threadpool.c:1619: Test failed: expected result 402, got 400 threadpool.c:1619: Test failed: expected result 404, got 402 threadpool.c:1619: Test failed: expected result 406, got 404 threadpool.c:1619: Test failed: expected result 408, got 406 threadpool.c:1619: Test failed: expected result 410, got 408 threadpool.c:1619: Test failed: expected result 412, got 410 threadpool.c:1619: Test failed: expected result 414, got 412 threadpool.c:1619: Test failed: expected result 416, got 414 threadpool.c:1619: Test failed: expected result 418, got 416 threadpool.c:1619: Test failed: expected result 420, got 418 threadpool.c:1619: Test failed: expected result 422, got 420 threadpool.c:1619: Test failed: expected result 424, got 422 threadpool.c:1619: Test failed: expected result 426, got 424 threadpool.c:1619: Test failed: expected result 428, got 426 threadpool.c:1619: Test failed: expected result 430, got 428 threadpool.c:1619: Test failed: expected result 432, got 430 threadpool.c:1619: Test failed: expected result 434, got 432 threadpool.c:1619: Test failed: expected result 436, got 434 threadpool.c:1619: Test failed: expected result 438, got 436 threadpool.c:1619: Test failed: expected result 440, got 438 threadpool.c:1619: Test failed: expected result 442, got 440 threadpool.c:1619: Test failed: expected result 444, got 442 threadpool.c:1619: Test failed: expected result 446, got 444 threadpool.c:1619: Test failed: expected result 448, got 446 threadpool.c:1619: Test failed: expected result 450, got 448 threadpool.c:1619: Test failed: expected result 452, got 450 threadpool.c:1619: Test failed: expected result 454, got 452 threadpool.c:1619: Test failed: expected result 456, got 454 threadpool.c:1619: Test failed: expected result 458, got 456 threadpool.c:1619: Test failed: expected result 460, got 458 threadpool.c:1619: Test failed: expected result 462, got 460 threadpool.c:1619: Test failed: expected result 464, got 462 threadpool.c:1619: Test failed: expected result 466, got 464 threadpool.c:1619: Test failed: expected result 468, got 466 threadpool.c:1619: Test failed: expected result 470, got 468 threadpool.c:1619: Test failed: expected result 472, got 470 threadpool.c:1619: Test failed: expected result 474, got 472 threadpool.c:1619: Test failed: expected result 476, got 474 threadpool.c:1619: Test failed: expected result 478, got 476 threadpool.c:1619: Test failed: expected result 480, got 478 threadpool.c:1619: Test failed: expected result 482, got 480 threadpool.c:1619: Test failed: expected result 483, got 482
On 20.08.2016 21:26, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25284
Your paranoid android.
=== w7u (32 bit threadpool) === threadpool.c:367: Test failed: WaitForSingleObject returned 258 threadpool.c:379: Test failed: expected info.userdata = 0x10000, got 0 threadpool.c:390: Test failed: expected info.userdata = 0x10000, got 0 threadpool.c:409: Test failed: expected info.userdata = 1, got 0 threadpool.c:422: Test failed: expected info.userdata = 1, got 0 threadpool.c:424: Test failed: expected STATUS_PENDING, got 0 threadpool.c:427: Test failed: WaitForSingleObject returned 258
=== w864 (64 bit threadpool) === threadpool.c:1618: Test failed: WaitForSingleObject returned 258 threadpool.c:1619: Test failed: expected result 2, got 0 threadpool.c:1619: Test failed: expected result 4, got 2 threadpool.c:1619: Test failed: expected result 6, got 4 threadpool.c:1619: Test failed: expected result 8, got 6 threadpool.c:1619: Test failed: expected result 10, got 8 threadpool.c:1619: Test failed: expected result 12, got 10 threadpool.c:1619: Test failed: expected result 14, got 12
[...]
Too bad, I was hoping to fix all random failures. :( Nevertheless, this patch should still be an improvement. The test failures are not present in any of the following 4 test runs. Is there anything what could cause the testbot to freeze for a short time?
-
Marvin -
Sebastian Lackner