Re: This patch should fix bug 4863 - Icons in Notes Workspace

[Augusto Arcoverde da Rocha]

Hi all,

A little time ago I have sent this patch and now I'm asking to the
Wine devel community about the correctness of that code.

May be a fix for "Icons in Notes" bug would be incorporated in the
next Wine release with some peer-review efforts.

Regards,
Augusto Arcoverde da Rocha

On 7/21/06, Augusto Arcoverde da Rocha  wrote:
> Description:
> This patch should fix bug 4863 - Icons in Notes Workspace.
>
> ChangeLog:
> Making SetDIBits function compliant with MSDN documentation by
> ignoring the device context parameter if DIB parameter is informed as
> having a palette (DIB_PAL_COLORS).
>
> References:
> http://msdn.microsoft.com/library/default.asp?url=/library/en-us/gdi/bitmaps...
>
> Author:
> Augusto Arcoverde da Rocha <agarobr\at\yahoo.com.br>
>
> Notes:
> Since I wasn't successful learning more about internal representation
> of DIB structure, I couldn't make the apropriated test units for this
> fix, sorry.

This patch should fix bug 4863 - Icons in Notes Workspace

[Vijay Kiran Kamuju]

Please put a link to your patch that has been sent to wine patches.
So that interested people can easily locate it and review it.

Thanks,
VJ

On 8/8/06, Augusto Arcoverde da Rocha  wrote:
> Hi all,
>
> A little time ago I have sent this patch and now I'm asking to the
> Wine devel community about the correctness of that code.
>
> May be a fix for "Icons in Notes" bug would be incorporated in the
> next Wine release with some peer-review efforts.
>
> Regards,
> Augusto Arcoverde da Rocha
>
> On 7/21/06, Augusto Arcoverde da Rocha  wrote:
> > Description:
> > This patch should fix bug 4863 - Icons in Notes Workspace.
> >
> > ChangeLog:
> > Making SetDIBits function compliant with MSDN documentation by
> > ignoring the device context parameter if DIB parameter is informed as
> > having a palette (DIB_PAL_COLORS).
> >
> > References:
> > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/gdi/bitmaps...
> >
> > Author:
> > Augusto Arcoverde da Rocha <agarobr\at\yahoo.com.br>
> >
> > Notes:
> > Since I wasn't successful learning more about internal representation
> > of DIB structure, I couldn't make the apropriated test units for this
> > fix, sorry.

This patch should fix bug 4863 - Icons in Notes Workspace

[Dan Kegel]

And weren't you going to work on a conformance test for this?

On 8/8/06, Vijay Kiran Kamuju  wrote:
> Please put a link to your patch that has been sent to wine patches.
> So that interested people can easily locate it and review it.
>
> Thanks,
> VJ
>
> On 8/8/06, Augusto Arcoverde da Rocha  wrote:
> > Hi all,
> >
> > A little time ago I have sent this patch and now I'm asking to the
> > Wine devel community about the correctness of that code.
> >
> > May be a fix for "Icons in Notes" bug would be incorporated in the
> > next Wine release with some peer-review efforts.
> >
> > Regards,
> > Augusto Arcoverde da Rocha
> >
> > On 7/21/06, Augusto Arcoverde da Rocha  wrote:
> > > Description:
> > > This patch should fix bug 4863 - Icons in Notes Workspace.
> > >
> > > ChangeLog:
> > > Making SetDIBits function compliant with MSDN documentation by
> > > ignoring the device context parameter if DIB parameter is informed as
> > > having a palette (DIB_PAL_COLORS).
> > >
> > > References:
> > > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/gdi/bitmaps...
> > >
> > > Author:
> > > Augusto Arcoverde da Rocha <agarobr\at\yahoo.com.br>
> > >
> > > Notes:
> > > Since I wasn't successful learning more about internal representation
> > > of DIB structure, I couldn't make the apropriated test units for this
> > > fix, sorry.

This patch should fix bug 4863 - Icons in Notes Workspace

[Augusto Arcoverde da Rocha]

Here is the link to the patch which I have sent (thanks VJ):
http://winehq.org/pipermail/wine-patches/2006-July/028932.html

And the link to the bug report and the subsequent discussion on Wine
bugzilla is:
http://bugs.winehq.org/show_bug.cgi?id=4863

About working on a conformance test, as I have said on the bug report,
I haven't the knowledge to validate the resultant DIB structure
returned from SetDIBits function. But I still have great interest in
learning and contributing with Wine commuinty and if someone helps me
understand the DIB structure, I will implement a conformance test for
this bug.

Regards,
Augusto Arcoverde da Rocha

On 8/8/06, Dan Kegel  wrote:
> And weren't you going to work on a conformance test for this?
>
> On 8/8/06, Vijay Kiran Kamuju  wrote:
> > Please put a link to your patch that has been sent to wine patches.
> > So that interested people can easily locate it and review it.
> >
> > Thanks,
> > VJ

This patch should fix bug 4863 - Icons in Notes Workspace

[Huw Davies]

On Wed, Aug 09, 2006 at 06:29:56PM -0300, Augusto Arcoverde da Rocha wrote:
> Here is the link to the patch which I have sent (thanks VJ):
> http://winehq.org/pipermail/wine-patches/2006-July/028932.html
>
> And the link to the bug report and the subsequent discussion on Wine
> bugzilla is:
> http://bugs.winehq.org/show_bug.cgi?id=4863
>
> About working on a conformance test, as I have said on the bug report,
> I haven't the knowledge to validate the resultant DIB structure
> returned from SetDIBits function. But I still have great interest in
> learning and contributing with Wine commuinty and if someone helps me
> understand the DIB structure, I will implement a conformance test for
> this bug.

It's still not clear to me what the bug is.  Could you indicate which
functions are being called by Notes are causing the problem.  A (very
small) bit of a relay trace would help.

Huw.