ListView_InsertColumn() question

[Andrew Talbot]

Can you verify something for me, please?

The SDK declares ListView_InsertColumn() as:

int ListView_InsertColumn(
    HWND hwnd,
    int iCol,
    const LPLVCOLUMN pcol
);

In commctrl.h, we have:

#define ListView_InsertColumnA(hwnd,iCol,pcol) \
    (INT)SNDMSGA((hwnd),LVM_INSERTCOLUMNA,(WPARAM)(INT)(iCol),(LPARAM)(const LVCOLUMNA *)(pcol))
#define ListView_InsertColumnW(hwnd,iCol,pcol) \
    (INT)SNDMSGW((hwnd),LVM_INSERTCOLUMNW,(WPARAM)(INT)(iCol),(LPARAM)(const LVCOLUMNW *)(pcol))
#define ListView_InsertColumn WINELIB_NAME_AW(ListView_InsertColumn)

Given (for a type T) that const T * and T const * are equivalent, and given
the left-to-right nature of pointer declarations, am I not right in thinking
that const LPLVCOLUMN pcol is really equivalent to:

LVCOLUMN * const pcol;

not

const LVCOLUMN *pcol;

?

Thanks,

-- Andy.

ListView_InsertColumn() question {revised]

[Andrew Talbot]

[I meant to say that pointer declarations are read right-to-left, not
left-to-right. So the corrected question is:]

Can you verify something for me, please?

The SDK declares ListView_InsertColumn() as:

int ListView_InsertColumn(
    HWND hwnd,
    int iCol,
    const LPLVCOLUMN pcol
);

In commctrl.h, we have:

#define ListView_InsertColumnA(hwnd,iCol,pcol) \
    (INT)SNDMSGA((hwnd),LVM_INSERTCOLUMNA,(WPARAM)(INT)(iCol),(LPARAM)(const
    LVCOLUMNA *)(pcol))
#define ListView_InsertColumnW(hwnd,iCol,pcol) \
    (INT)SNDMSGW((hwnd),LVM_INSERTCOLUMNW,(WPARAM)(INT)(iCol),(LPARAM)(const
    LVCOLUMNW *)(pcol))
#define ListView_InsertColumn WINELIB_NAME_AW(ListView_InsertColumn)

Given (for a type T) that const T * and T const * are equivalent, and
given the right-to-left nature of pointer declarations, am I not right in
thinking that const LPLVCOLUMN pcol is really equivalent to:

LVCOLUMN * const pcol;

not

const LVCOLUMN *pcol;

?

Thanks,

-- Andy.

ListView_InsertColumn() question {revised]

[Dmitry Timoshkov]

"Andrew Talbot"  wrote:
> Given (for a type T) that const T * and T const * are equivalent, and
> given the right-to-left nature of pointer declarations, am I not right in
> thinking that const LPLVCOLUMN pcol is really equivalent to:
>
> LVCOLUMN * const pcol;
>
> not
>
> const LVCOLUMN *pcol;
>
> ?

I think yes. A simple test with MSVC compiler and gcc confirms that as well.

ListView_InsertColumn() question {revised]

[Dmitry Timoshkov]

"Dmitry Timoshkov"  wrote:
> "Andrew Talbot"  wrote:
> > Given (for a type T) that const T * and T const * are equivalent, and
> > given the right-to-left nature of pointer declarations, am I not right in
> > thinking that const LPLVCOLUMN pcol is really equivalent to:
> >
> > LVCOLUMN * const pcol;

This one is an equivalent of 'LPLVCOLUMN pcol';
> > not
> >
> > const LVCOLUMN *pcol;
> >
> > ?
>
> I think yes. A simple test with MSVC compiler and gcc confirms that as well.

Sorry for the ambiguous answer, I missed "not" in "am I not", and it slightly
confused me, leading to an inversed logic in thinking.

ListView_InsertColumn() question {revised]

[Dmitry Timoshkov]

I really can't type today.

"Dmitry Timoshkov"  wrote:
> > > LVCOLUMN * const pcol;
>
> This one is an equivalent of 'LPLVCOLUMN pcol';

s/'LPLVCOLUMN pcol'/'const LPLVCOLUMN pcol'

ListView_InsertColumn() question {revised]

[Andrew Talbot]

Dmitry Timoshkov wrote:
> I really can't type today.

I'm glad I'm not the only one. :))

-- A.

ListView_InsertColumn() question [revised]

[Andrew Talbot]

Dmitry Timoshkov wrote:
> Sorry for the ambiguous answer, I missed "not" in "am I not", and it
> slightly confused me, leading to an inversed logic in thinking.

I should have made the question less verbose. :)

I think we are agreeing that

LVCOLUMN * const pcol;

is the correct equivalent of

const LPLVCOLUMN pcol;

So it would seem that I need to patch commctrl.h, and this should also have
a significance for the cast-qual warning I get for taskmgr/column.c.

Thanks, Dmitry!

-- Andy.