2010/6/2 Sven Baars sven.wine@gmail.com
programs/cmd/Nl.rc | 194 ++++++++++++++++++++++++++++----------------------- 1 files changed, 106 insertions(+), 88 deletions(-)
Hi Sven,
Some remarks: - You shouldn't change the line length as it makes the patch unnecessarily big, for no change in text (for the affected hunks) - "bestaat keert de controle terug naar het bestand dat het aanriep. DE CALL\n" => "DE" should be "De"
Frédéric
On 06/03/2010 03:28 PM, Frédéric Delanoy wrote:
2010/6/2 Sven Baars <sven.wine@gmail.com mailto:sven.wine@gmail.com>
--- programs/cmd/Nl.rc | 194 ++++++++++++++++++++++++++++----------------------- 1 files changed, 106 insertions(+), 88 deletions(-)
Hi Sven,
Some remarks:
- You shouldn't change the line length as it makes the patch
unnecessarily big, for no change in text (for the affected hunks)
I disagree here. I think having it cut down from 100+ is for the better.
Hello Frédéric,
Frédéric Delanoy wrote:
2010/6/2 Sven Baars <sven.wine@gmail.com mailto:sven.wine@gmail.com>
--- programs/cmd/Nl.rc | 194 ++++++++++++++++++++++++++++----------------------- 1 files changed, 106 insertions(+), 88 deletions(-)
Hi Sven,
Some remarks:
- You shouldn't change the line length as it makes the patch
unnecessarily big, for no change in text (for the affected hunks)\
I changed the line length, to be more consistent with the English translation. As it was done before, you just had the same words on a line as in English, but since Dutch usually needs more words than English, the lines didn't fit on a standard terminal. Now it's more-or-less in sync with the line length of the English translation, which is in my opinion a good thing.
- "bestaat keert de controle terug naar het bestand dat het aanriep.
DE CALL\n" => "DE" should be "De"
Thanks. I'll resend.
Frédéric
Sven