Hello M.
What is wrong with detecting the version, and branching the test code accordingly? Other tests do that IIRC. I think that is a better solution, if the version selector in winecfg is still going to be meaningful (registry).
How about fixing the functions as well (like IsWindowUnicode), so it returns the correct data according to the version in winecfg (registry).
However, i do like the irony in your example :-)
/pedro
On Tue, 2008-02-12 at 18:09 -0800, Maarten Lankhorst wrote:
Hi all,
I'm very close to passing the whole wine conformance suite on my pc. The only tests failing are in user32. These tests are failing in any version of windows though. How do I make them pass on at least 1 version of windows and wine? Would patches to make it run on xp and wine be accepted?
And if I can succeed with that, how do I make it work with other versions of windows as well.
Cheers, Maarten.
An example is IsWindowUnicode. It always returns TRUE on XP, but it won't do that on 9x. That would mean something like: ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?");
On Feb 12, 2008 8:16 PM, Peter Dons Tychsen donpedro@tdcadsl.dk wrote:
Hello M.
What is wrong with detecting the version, and branching the test code accordingly? Other tests do that IIRC. I think that is a better solution, if the version selector in winecfg is still going to be meaningful (registry).
The only time the tests should check for the windows version is if we know an app does the same thing, which is hardly ever.
P.S. Please bottom-post on this mailing list.
On Tuesday 12 February 2008, James Hawkins wrote:
On Feb 12, 2008 8:16 PM, Peter Dons Tychsen donpedro@tdcadsl.dk wrote:
Hello M.
What is wrong with detecting the version, and branching the test code accordingly? Other tests do that IIRC. I think that is a better solution, if the version selector in winecfg is still going to be meaningful (registry).
The only time the tests should check for the windows version is if we know an app does the same thing, which is hardly ever.
Well, if we have an old app from win9x times, it will expect windows 95 behavior, without checking for windows version of course.
So if Wine is set to impersonate win95, then it should behave like on win95 and the tests should check windows (here: wine) version to select a proper test. Such a version-specific test should pass on win95 and wine with win95 personality chosen. It should also pass on other versions, by choosing a different path (and possibly doing nothing if it doesn't apply to that windows version).
So, for example, methinks all applicable unicode tests should be disabled on the early win95 versions which had no such support (if so bolt-on unicode is detected).
Wouldn't that make sense?
Cheers, Kuba
-
James Hawkins -
Kuba Ober -
Peter Dons Tychsen