Re: dxdiagn: PhysicalMemory parameter is a string not long long

[Rob Shearman]

2008/6/21 Vitaliy Margolen :
> @@ -300,6 +300,7 @@ static HRESULT DXDiag_InitDXDiagSystemInfoContainer(IDxDiagContainer* pSubCont)
>    GlobalMemoryStatusEx( &msex );
>    V_VT(&v) = VT_UI8;
>    V_UI8(&v) = msex.ullTotalPhys;
> -
>
> VariantChangeType(&v, &v, 0, VT_BSTR);
> IDxDiagContainerImpl_AddProp(pSubCont, ullPhysicalMemory, &v);
>
> info.dwOSVersionInfoSize = sizeof(info);

You need to call VariantClear otherwise you will leak memory.

dxdiagn: PhysicalMemory parameter is a string not long long

[Vitaliy Margolen]

Rob Shearman wrote:
> 2008/6/21 Vitaliy Margolen :
> > @@ -300,6 +300,7 @@ static HRESULT DXDiag_InitDXDiagSystemInfoContainer(IDxDiagContainer* pSubCont)
> >    GlobalMemoryStatusEx( &msex );
> >    V_VT(&v) = VT_UI8;
> >    V_UI8(&v) = msex.ullTotalPhys;
> > -
> >
> > VariantChangeType(&v, &v, 0, VT_BSTR);
> > IDxDiagContainerImpl_AddProp(pSubCont, ullPhysicalMemory, &v);
> >
> > info.dwOSVersionInfoSize = sizeof(info);
>
> You need to call VariantClear otherwise you will leak memory.

Thank you for spotting it. The fixed patch on the way.

Vitaliy.