Sending patches for bug #22918

[Misha Koshelev]

Dear All:

Congrats on 1.2!

I have begun sending my patches from my repository:
http://github.com/misha680/wine/commits/master

Specifically, I have sent the first 10 patches (of approx 70 currently).

I look forward to your comments/commits ;)

Also, if anyone knows how to make git format-patch only output the 10
_bottom-most_ patches, please let me know.

I tried:
git format-patch -n --stdout origin --branches --not --remotes=upstream
-10 | git imap-send

(note the -10 in the command above)

but that sends the 10 topmost patches, sadly :(

Thanks again!
Misha

[Hin-Tak Leung]

Misha Koshelev wrote:
> Dear All:
>
> Congrats on 1.2!
>
> I have begun sending my patches from my repository:
> http://github.com/misha680/wine/commits/master
>
> Specifically, I have sent the first 10 patches (of approx 70 currently).
>
> I look forward to your comments/commits ;)
>
> Also, if anyone knows how to make git format-patch only output the 10
> _bottom-most_ patches, please let me know.
>
> I tried:
> git format-patch -n --stdout origin --branches --not --remotes=upstream
> -10 | git imap-send
>
> (note the -10 in the command above)
>
> but that sends the 10 topmost patches, sadly :(

Bottom of git-format-patch man-page, example:

Extract commits between revisions R1 and R2, and apply them on top of the 
current branch using git am to cherry-pick them:

$ git format-patch -k --stdout R1..R2 | git am -3 -k

also read 'man git-rev-parse' about how to do address revision . You want ^10 or
  ~10 .

[Eliot Blennerhassett]

On 17/07/10 10:22, Misha Koshelev wrote:
> Also, if anyone knows how to make git format-patch only output the 10
> _bottom-most_ patches, please let me know.

Partial solution:

use git format-patch without the --stdout, to generate all the patches
as files, then git send-email or imap-send  <some selection of patch files>

[Vitaliy Margolen]

On 07/16/2010 04:22 PM, Misha Koshelev wrote:
> Also, if anyone knows how to make git format-patch only output the 10
> _bottom-most_ patches

If you have 70 patches in your tree then:
git format-patch  HEAD~70..HEAD~60

Vitaliy.

[James McKenzie]

Misha Koshelev wrote:
> Dear All:
>
> Congrats on 1.2!
>
> I have begun sending my patches from my repository:
> http://github.com/misha680/wine/commits/master

Misha:

Might I make a tiny suggestion:  Send in one set of patches and wait for 
AJ's and others feedback.  Make appropriate corrections and then 
resubmit.  Repeat until the first set is accepted and incorporated into 
Wine.  Go back to your remaining patches and make all necessary 
corrections.  This will save your time and reduce the number of 
correction messages.

If you need to, post them to the Wine Developers list, but I remember 
you doing this already.

Seventy patches is a very large number of patches to submit all in one go.

James McKenzie

[Misha Koshelev]

On Fri, 2010-07-16 at 20:08 -0700, James McKenzie wrote:
> Misha Koshelev wrote:
> > Dear All:
> >
> > Congrats on 1.2!
> >
> > I have begun sending my patches from my repository:
> > http://github.com/misha680/wine/commits/master
>
> Misha:
>
> Might I make a tiny suggestion:  Send in one set of patches and wait for 
> AJ's and others feedback.  Make appropriate corrections and then 
> resubmit.  Repeat until the first set is accepted and incorporated into 
> Wine.  Go back to your remaining patches and make all necessary 
> corrections.  This will save your time and reduce the number of 
> correction messages.
>
> If you need to, post them to the Wine Developers list, but I remember 
> you doing this already.
>
> Seventy patches is a very large number of patches to submit all in one go.
>
> James McKenzie

Thank you very much for your suggestion. I apologize if I was not clear,
I am actually sending 10 patches from my repository, waiting for
comments, then sending 10 more, etc.

I appreciate the hint and will appreciate all the feedback too.

I have already sent some of the patches out for comments (Henri, Dan,
etc. - thank you so much) and so am hoping this will go speedier rather
than not.

In any case, I am waiting to hear from AJ/developers on first 10.
Unfortunately, the test bot failures are due to changes in spec files
not resulting in DLL recompilation :( I believe that with proper dll
recompilation, the errors are a non-issue.

Thank you
Misha

p.s. Do I remember correctly AJ does not commit on weekends?

[Frédéric Delanoy]

On Sat, Jul 17, 2010 at 14:43, Misha Koshelev  wrote:
> On Fri, 2010-07-16 at 20:08 -0700, James McKenzie wrote:
> > Misha Koshelev wrote:
>
> p.s. Do I remember correctly AJ does not commit on weekends?

Exactly. 5 times a week should be sufficient ;)

[Misha Koshelev]

On Sat, 2010-07-17 at 15:39 +0200, Frédéric Delanoy wrote:
> On Sat, Jul 17, 2010 at 14:43, Misha Koshelev  wrote:
> > On Fri, 2010-07-16 at 20:08 -0700, James McKenzie wrote:
> > > Misha Koshelev wrote:
> >
> > p.s. Do I remember correctly AJ does not commit on weekends?
>
> Exactly. 5 times a week should be sufficient ;)

Thanks guys, I used the following scripts to send the patches
(attached).

Just out of curiosity - is there a way to automatically append the (try
#) to the patches...

I seem to remember having this functionality...

Thank you!
Misha