Re: wininet: ftp test hangs behind firewall, so turn it off by default

[Alexandre Julliard]

"Dan Kegel"  writes:
> This gets rid of one more place I have to do 'wineserver -k' to
> make tests complete.

I don't think it really hangs, it just takes a long time to complete.
> It would be better to embed a little ftp server into the test,
> and connect to that instead of a public one, but that would
> be a pain.

No, we clearly want to run the test against a real ftp server. Running
it against different types of servers would be even better. What we
should probably do is try to connect to a server on localhost first,
this way people can install the server of their choice to provide more
test coverage.

wininet: ftp test hangs behind firewall, so turn it off by default

[Hans Leidekker]

On Tuesday 23 October 2007 12:37:46 Alexandre Julliard wrote:
> > This gets rid of one more place I have to do 'wineserver -k' to
> > make tests complete.
>
> I don't think it really hangs, it just takes a long time to complete.

It may have really hung before for some people. I remember leaving the
test running for more than half an hour and it was still stuck, whereas
now it completes within minutes.

I didn't verify this but the logical explanation seems to be that in
the previous setting the incoming connection got blocked by a firewall,
while the test sat there waiting for it in a blocking accept or analogous
call. If so, there could be another bug lurking in our timeout handling.

-Hans

wininet: ftp test hangs behind firewall, so turn it off by default

[Dan Kegel]

On 10/23/07, Alexandre Julliard  wrote:
> I don't think it really hangs, it just takes a long time to complete.

That could be.  Waiting for it to finish is like waiting for paint to dry,
though.  It took six minutes just now, and I'm on a fast connection.
If we're going to keep it, can we shorten it so it passes in one minute or less?
> > It would be better to embed a little ftp server into the test,
> > and connect to that instead of a public one, but that would
> > be a pain.
>
> No, we clearly want to run the test against a real ftp server. Running
> it against different types of servers would be even better. What we
> should probably do is try to connect to a server on localhost first,
> this way people can install the server of their choice to provide more
> test coverage.

That would be an improvement.
- Dan