Re: Wine engine fix

[Dimitrie O. Paun]

On March 22, 2002 02:58 pm, Eric Pouech wrote:
> usually fixed fonts are in MODERN family

[...[
> - if (ptm->tmPitchAndFamily & TMPF_FIXED_PITCH)
> -
>    ptm->tmPitchAndFamily |= FF_ROMAN;
> - else
> -
>    ptm->tmPitchAndFamily |= FF_MODERN;

Shouldn't this be the other way around?

Wine engine fix

[Eric Pouech]

"Dimitrie O. Paun" a écrit :
> On March 22, 2002 02:58 pm, Eric Pouech wrote:
> > usually fixed fonts are in MODERN family
>
> [...[
> > - if (ptm->tmPitchAndFamily & TMPF_FIXED_PITCH)
> > -
> >    ptm->tmPitchAndFamily |= FF_ROMAN;
> > - else
> > -
> >    ptm->tmPitchAndFamily |= FF_MODERN;
>
> Shouldn't this be the other way around?

no... the TMPF_FIXED_PITCH is a f**** m**** API
TMPF_FIXED_PITCH is set when the font isn't fixed... go figure

A+

Wine engine fix

[Andreas Mohr]

On Fri, Mar 22, 2002 at 09:55:35PM +0100, Eric Pouech wrote:
> "Dimitrie O. Paun" a écrit :
> > On March 22, 2002 02:58 pm, Eric Pouech wrote:
> > > usually fixed fonts are in MODERN family
> >
> > [...[
> > > - if (ptm->tmPitchAndFamily & TMPF_FIXED_PITCH)
> > > -
> > >    ptm->tmPitchAndFamily |= FF_ROMAN;
> > > - else
> > > -
> > >    ptm->tmPitchAndFamily |= FF_MODERN;
> >
> > Shouldn't this be the other way around?
>
> no... the TMPF_FIXED_PITCH is a f**** m**** API
> TMPF_FIXED_PITCH is set when the font isn't fixed... go figure

Well, then maybe better add a comment so that everyone never fails
to see this.

Wine engine fix

[Huw D M Davies]

On Fri, Mar 22, 2002 at 10:16:09PM +0100, Andreas Mohr wrote:
> On Fri, Mar 22, 2002 at 09:55:35PM +0100, Eric Pouech wrote:
> > "Dimitrie O. Paun" a écrit :
> > > On March 22, 2002 02:58 pm, Eric Pouech wrote:
> > > > usually fixed fonts are in MODERN family
> > >
> > > [...[
> > > > - if (ptm->tmPitchAndFamily & TMPF_FIXED_PITCH)
> > > > -
> > > >    ptm->tmPitchAndFamily |= FF_ROMAN;
> > > > - else
> > > > -
> > > >    ptm->tmPitchAndFamily |= FF_MODERN;
> > >
> > > Shouldn't this be the other way around?
> >
> > no... the TMPF_FIXED_PITCH is a f**** m**** API
> > TMPF_FIXED_PITCH is set when the font isn't fixed... go figure
>
> Well, then maybe better add a comment so that everyone never fails
> to see this.

There is one about 5 lines above this patch...

[actually I have a better patch than this that uses the panose data to get the
correct FF_* info, but that's another story]
Huw.