Re: msrle32: Use the correct number of colors when biClrUsed = 0 (try 2)

[Alexandre Julliard]

Bruno Jesus  writes:
> @@ -1647,27 +1655,33 @@ static LRESULT DecompressBegin(CodecInfo *pi, LPCBITMAPINFOHEADER lpbiIn,
>
> if (lpbiIn->biCompression != BI_RGB)
>    {
> - int colors;
> -
> - if (lpbiIn->biClrUsed == 0)
> -
>  colors = 1 << lpbiIn->biBitCount;
> - else
> -
>  colors = lpbiIn->biClrUsed;

I don't think you want to do that for biBitCount > 8.

msrle32: Use the correct number of colors when biClrUsed = 0 (try 2)

[Bruno Jesus]

On Tuesday, March 15, 2016, Alexandre Julliard <[e-mail]
> wrote:
> Bruno Jesus  writes:
> > @@ -1647,27 +1655,33 @@ static LRESULT DecompressBegin(CodecInfo *pi,
>
> LPCBITMAPINFOHEADER lpbiIn,
> > if (lpbiIn->biCompression != BI_RGB)
> >    {
> > - int colors;
> > -
> > - if (lpbiIn->biClrUsed == 0)
> > -
> >  colors = 1 << lpbiIn->biBitCount;
> > - else
> > -
> >  colors = lpbiIn->biClrUsed;
>
> I don't think you want to do that for biBitCount > 8.

I'm not near the source code now but AFAIR DecompressQuery would refuse
such bitmap because it does not support biClrUsed > 0 when bit count > 8.
But I will clarify that in a third version, certainly it would be a waste
of memory to allocate memory unnecessarely.