Re: riched20: fix placement of crlf on font table streamout

[Austin English]

On Sat, Apr 25, 2009 at 12:56 PM, Massimo Del Fedele  wrote:
> In riched20/writer.c the font table was erroneously streamed out with a \r\n
> after
> each font, instead of end of font table. Can be easily checked on rtf output
> from windows. AutoCAD 2005 was very picky with this, expecting an opened or
> closed bracked after each font, crashing if not found.
> Fixes Bug 14827

Can you add a testcase for this?

riched20: fix placement of crlf on font table streamout

[Massimo Del Fedele]

Austin English ha scritto:
> On Sat, Apr 25, 2009 at 12:56 PM, Massimo Del Fedele  wrote:
> > In riched20/writer.c the font table was erroneously streamed out with a \r\n
> > after
> > each font, instead of end of font table. Can be easily checked on rtf output
> > from windows. AutoCAD 2005 was very picky with this, expecting an opened or
> > closed bracked after each font, crashing if not found.
> > Fixes Bug 14827
>
> Can you add a testcase for this?

Done, even if it was quite visible on windows RTF output.

Ciao

Max

riched20: fix placement of crlf on font table streamout

[Austin English]

On Sat, Apr 25, 2009 at 2:23 PM, Massimo Del Fedele  wrote:
> Austin English ha scritto:
> > On Sat, Apr 25, 2009 at 12:56 PM, Massimo Del Fedele 
> > wrote:
> > > In riched20/writer.c the font table was erroneously streamed out with a
> > > \r\n
> > > after
> > > each font, instead of end of font table. Can be easily checked on rtf
> > > output
> > > from windows. AutoCAD 2005 was very picky with this, expecting an opened
> > > or
> > > closed bracked after each font, crashing if not found.
> > > Fixes Bug 14827
> >
> > Can you add a testcase for this?
>
> Done, even if it was quite visible on windows RTF output.

Thanks.

Even if it's easy to see, it helps prevent it from regressing in the future.