Re: [PATCH 1/2 v2] reg: Account for sizeof(WCHAR) when resizing the value name buffer during the query operation

[Alexandre Julliard]

Hugh McMaster  writes:
> Changes since v1:
> - Handle HeapReAlloc() failure

This is a stand-alone app, so adding a couple of helpers that die on
allocation failure would probably be a better choice than checking
everywhere.

[PATCH 1/2 v2] reg: Account for sizeof(WCHAR) when resizing the value name buffer during the query operation

[Hugh McMaster]

> On 21 Jul 2017, at 11:14 pm, Alexandre Julliard wrote:
>
> Hugh McMaster writes:
> > Changes since v1:
> > - Handle HeapReAlloc() failure
>
> This is a stand-alone app, so adding a couple of helpers that die on
> allocation failure would probably be a better choice than checking
> everywhere.

We can probably reuse the resize_buffer() and error_exit() functions from regedit to make things easier.

Unfortunately, I don't have time to make those changes right now. But the sizeof(WCHAR) allocation should ideally be fixed before today's release. So you might like to take the original patch instead. I'll leave that decision up to you.

Thanks for the feedback.