Your patch isn't correct. Just try this:
rm -rf ~/.wine wineprefixcreate winecfg
Go to Graphics tab and set any resolution more than 127 DPI (for example, 150). Close winecfg. Run it again. Now you have 63 DPI (instead of 150; in fact anything bigger than 127 DPI will not be displayed correctly in winecfg).
This problem was already solved in this patch [1] by Nigel Liang. Unfortunately, it wasn't accepted and Nigel didn't tried to ask why it was rejected or to resend it. I think I will go ahead and resend his patch.
[1] http://www.winehq.org/pipermail/wine-patches/2007-October/044977.html
On Tue, Mar 4, 2008 at 1:52 PM, L. Rahyen research@science.su wrote:
Your patch isn't correct. Just try this:rm -rf ~/.wine wineprefixcreate winecfg
Go to Graphics tab and set any resolution more than 127 DPI (for example,150). Close winecfg. Run it again. Now you have 63 DPI (instead of 150; in fact anything bigger than 127 DPI will not be displayed correctly in winecfg).
This problem was already solved in this patch [1] by Nigel Liang.Unfortunately, it wasn't accepted and Nigel didn't tried to ask why it was rejected or to resend it. I think I will go ahead and resend his patch.
[1] http://www.winehq.org/pipermail/wine-patches/2007-October/044977.html
Please apply Nigel's patch, thus reverting my own. I tested on my machine, but didn't catch this problem.
Thanks Rahyen for catching this, and sorry for the mistake.
-Austin
"L. Rahyen" research@science.su wrote:
This problem was already solved in this patch [1] by Nigel Liang. Unfortunately, it wasn't accepted and Nigel didn't tried to ask why it was rejected or to resend it. I think I will go ahead and resend his patch.
[1] http://www.winehq.org/pipermail/wine-patches/2007-October/044977.html
MultiByteToWideChar is that patch passes negative length for the destination buffer which is incorrect.
On Wednesday March 5 2008 02:55:34 Dmitry Timoshkov wrote:
"L. Rahyen" research@science.su wrote:
This problem was already solved in this patch [1] by Nigel Liang. Unfortunately, it wasn't accepted and Nigel didn't tried to ask why it was rejected or to resend it. I think I will go ahead and resend his patch.
[1] http://www.winehq.org/pipermail/wine-patches/2007-October/044977.html
MultiByteToWideChar is that patch passes negative length for the destination buffer which is incorrect.
That means patch "winecfg: Fix overflow in the DPI field at the Graphics tab for DPI value bigger than 127" is incorrect too. I think I will write today better patch myself from scratch for this bug (after reading some docs about MultiByteToWideChar). After Austin's patch "Revert: winecfg raise max screen resolution to 160 DPI" will be accepted I will send better fix for this bug (9715).
-
Austin English -
Dmitry Timoshkov -
L. Rahyen