On 29 August 2011 19:20, Stefan Dösinger stefan@codeweavers.com wrote:
+/* Note that this function writes the full sizeof(DDSURFACEDESC2) size, don't use it
So no need to clear it first.
On Monday 29 August 2011 19:40:13 Henri Verbeet wrote:
On 29 August 2011 19:20, Stefan Dösinger stefan@codeweavers.com wrote:
+/* Note that this function writes the full sizeof(DDSURFACEDESC2) size, don't use it
So no need to clear it first.
Well, the clear is part of the code that writes to the structure. The rest of the code only writes members that are set in the source DDSURFACEDESC.
On 29 August 2011 20:53, Stefan Dösinger stefan@codeweavers.com wrote:
On Monday 29 August 2011 19:40:13 Henri Verbeet wrote:
On 29 August 2011 19:20, Stefan Dösinger stefan@codeweavers.com wrote:
+/* Note that this function writes the full sizeof(DDSURFACEDESC2) size, don't use it
So no need to clear it first.
Well, the clear is part of the code that writes to the structure. The rest of the code only writes members that are set in the source DDSURFACEDESC.
If they aren't set in the source structure we should never read them anyway.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 29.08.2011 um 21:38 schrieb Henri Verbeet:
On 29 August 2011 20:53, Stefan Dösinger stefan@codeweavers.com wrote:
On Monday 29 August 2011 19:40:13 Henri Verbeet wrote:
On 29 August 2011 19:20, Stefan Dösinger stefan@codeweavers.com wrote:
+/* Note that this function writes the full sizeof(DDSURFACEDESC2) size, don't use it
So no need to clear it first.
Well, the clear is part of the code that writes to the structure. The rest of the code only writes members that are set in the source DDSURFACEDESC.
If they aren't set in the source structure we should never read them anyway.
Technically that's true for this specific function since the result is only used by our code and never the application. Yet I prefer to keep the memset for consistency with other code that handles DDSURFACEDESC(2) structures.
On Monday 29 August 2011 21:54:52 Stefan Dösinger wrote:
Technically that's true for this specific function since the result is only used by our code and never the application. Yet I prefer to keep the memset for consistency with other code that handles DDSURFACEDESC(2) structures.
I tried to change the clear value to 0xff instead of 0x00 and got test failures. So it looks like we have buggy code somewhere else. I'm investigating.
-
Henri Verbeet -
Stefan Dösinger