Re: winex11.drv: Add TIMESTAMP to X clipboard TARGETS

[Alexandre Julliard]

Andrey Vostrikov  writes:
> - else if(event->target == x11drv_atom(TIMESTAMP))  /*  Return event timestamp */
> - {
> -
>    /* TIMESTAMP selection request */
> -
>    XChangeProperty(display, request, rprop, event->target,
> -
>                    32, PropModeReplace, (unsigned char*)&event->time, 1);

That's not the correct timestamp.

winex11.drv: Add TIMESTAMP to X clipboard TARGETS

[Andrey Vostrikov]

Alexandre Julliard wrote:
> Andrey Vostrikov  writes:
> > - else if(event->target == x11drv_atom(TIMESTAMP))  /*  Return event timestamp */
> > - {
> > -
> >    /* TIMESTAMP selection request */
> > -
> >    XChangeProperty(display, request, rprop, event->target,
> > -
> >                    32, PropModeReplace, (unsigned char*)&event->time, 1);
>
> That's not the correct timestamp.

What would be the correct one then?
CurrentTime is zero and does not help. event->time is very close to what 
is needed and fixes an issue.

winex11.drv: Add TIMESTAMP to X clipboard TARGETS

[Alexandre Julliard]

Andrey Vostrikov  writes:
> Alexandre Julliard wrote:
> > Andrey Vostrikov  writes:
> > > - else if(event->target == x11drv_atom(TIMESTAMP))  /*  Return event timestamp */
> > > - {
> > > -
> > >    /* TIMESTAMP selection request */
> > > -
> > >    XChangeProperty(display, request, rprop, event->target,
> > > -
> > >                    32, PropModeReplace, (unsigned char*)&event->time, 1);
> >
> > That's not the correct timestamp.
>
> What would be the correct one then?

The time when we acquired the selection.

winex11.drv: Add TIMESTAMP to X clipboard TARGETS

[Andrey Vostrikov]

Alexandre Julliard wrote:
> Andrey Vostrikov  writes:
> > Alexandre Julliard wrote:
> > > Andrey Vostrikov  writes:
> > > > - else if(event->target == x11drv_atom(TIMESTAMP))  /*  Return event timestamp */
> > > > - {
> > > > -
> > > >    /* TIMESTAMP selection request */
> > > > -
> > > >    XChangeProperty(display, request, rprop, event->target,
> > > > -
> > > >                    32, PropModeReplace, (unsigned char*)&event->time, 1);
> > >
> > > That's not the correct timestamp.
> >
> > What would be the correct one then?
>
> The time when we acquired the selection.

Hi Alexandre,

This is updated patch. It obtains X server timestamp similar as in GTK+ 
library, by pinging X window when selection is acquired.

Best regards,
Andrey

winex11.drv: Add TIMESTAMP to X clipboard TARGETS

[Vincent Povirk]

You should send this to wine-patches if you want it to be reviewed. I
didn't see anything obviously wrong, at least.