Re: [SETUPAPI] SetupDiCreateDeviceInfo

[Paul Vriens]

> This patch implements SetupDiCreateDeviceInfoA and
> SetupDiCreateDeviceInfoW as
> stub.
>
> If something should be wrong with this patch, please let me know it :)
>
> Greets,
> Christian
>
> --
> Christian Gmeiner - student of computer science
>
> http://dxr3plugin.sf.net
> Wanna listen to good music? - http://www.purevolume.com/sinceyouaredead

Hi Christian,

I haven't checked if the logic is corret. But this certainly isn't:
> - if (DeviceDescription)
> - {
> -
>    DeviceDescriptionW = MultiByteToUnicode(DeviceDescription, CP_ACP);
> -
>    if (DeviceNameW == NULL) return FALSE;

Shouldn't that be DeviceDescriptionW?
> - if (DeviceNameW)
> -
>    MyFree(DeviceDescriptionW);
> - if (DeviceNameW)
> -
>    MyFree(DeviceDescriptionW);

Some typos here as well.

Cheers,

Paul

[SETUPAPI] SetupDiCreateDeviceInfo

[Christian Gmeiner]

Hi Paul,

thanks for this info.. will fix it and send in a new version of this patch, 
also i will use debugstr_w to fix two warnings.

Greets,
Christian
> > This patch implements SetupDiCreateDeviceInfoA and
> > SetupDiCreateDeviceInfoW as
> > stub.
> >
> > If something should be wrong with this patch, please let me know it :)
> >
> > Greets,
> > Christian
> >
> > --
> > Christian Gmeiner - student of computer science
> >
> > http://dxr3plugin.sf.net
> > Wanna listen to good music? - http://www.purevolume.com/sinceyouaredead
>
> Hi Christian,
>
> I haven't checked if the logic is corret. But this certainly isn't:
> > - if (DeviceDescription)
> > - {
> > -
> >    DeviceDescriptionW = MultiByteToUnicode(DeviceDescription,
> >
> > CP_ACP); +        if (DeviceNameW == NULL) return FALSE;
>
> Shouldn't that be DeviceDescriptionW?
> > - if (DeviceNameW)
> > -
> >    MyFree(DeviceDescriptionW);
> > - if (DeviceNameW)
> > -
> >    MyFree(DeviceDescriptionW);
>
> Some typos here as well.
>
> Cheers,
>
> Paul