On 3 March 2014 16:28, Matteo Bruni mbruni@codeweavers.com wrote:
dlls/d3dx9_36/effect.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index a4325af..0ec17c1 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -5294,8 +5294,10 @@ HRESULT WINAPI D3DXCreateEffectEx(struct IDirect3DDevice9 *device, const void *s struct ID3DXEffectImpl *object; HRESULT hr;
- FIXME("(%p, %p, %u, %p, %p, %p, %#x, %p, %p, %p): semi-stub\n", device, srcdata, srcdatalen, defines, include,
skip_constants, flags, pool, effect, compilation_errors);
- TRACE("device %p, srcdata %p, srcdatalen %u, defines %p, include %p,\n",
device, srcdata, srcdatalen, defines, include);- TRACE("skip_constants %p, flags %#x, pool %p, effect %p, compilation_errors %p.\n",
skip_constants, flags, pool, effect, compilation_errors);
Mostly just FWIW, I think it's generally nicer to keep that as a single TRACE.
2014-03-03 16:50 GMT+01:00 Henri Verbeet hverbeet@gmail.com:
On 3 March 2014 16:28, Matteo Bruni mbruni@codeweavers.com wrote:
dlls/d3dx9_36/effect.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index a4325af..0ec17c1 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -5294,8 +5294,10 @@ HRESULT WINAPI D3DXCreateEffectEx(struct IDirect3DDevice9 *device, const void *s struct ID3DXEffectImpl *object; HRESULT hr;
- FIXME("(%p, %p, %u, %p, %p, %p, %#x, %p, %p, %p): semi-stub\n", device, srcdata, srcdatalen, defines, include,
skip_constants, flags, pool, effect, compilation_errors);
- TRACE("device %p, srcdata %p, srcdatalen %u, defines %p, include %p,\n",
device, srcdata, srcdatalen, defines, include);- TRACE("skip_constants %p, flags %#x, pool %p, effect %p, compilation_errors %p.\n",
skip_constants, flags, pool, effect, compilation_errors);Mostly just FWIW, I think it's generally nicer to keep that as a single TRACE.
It makes sense and I can resend it changed no problem. Should I keep the '\n' in the middle of the TRACE message to print the TRACE over two lines?
On 3 March 2014 17:30, Matteo Bruni matteo.mystral@gmail.com wrote:
It makes sense and I can resend it changed no problem. Should I keep the '\n' in the middle of the TRACE message to print the TRACE over two lines?
I usually leave it out, and let the editor handle line wrapping.
-
Henri Verbeet -
Matteo Bruni