Re: Patch for adding Swedish localization

[Robert Shearman]

Daniel Nylander wrote:
> Here is the patch to add Swedish localization files to Wine.
> Sorry, this is my first patch using git and I'm really unsure if I did
> it correctly.

You need to use git-add to include the new files in the commit/patch you 
sent.

Patch for adding Swedish localization

[Daniel Nylander]

Robert Shearman skrev:
> Daniel Nylander wrote:
> > Here is the patch to add Swedish localization files to Wine.
> > Sorry, this is my first patch using git and I'm really unsure if I did
> > it correctly.
>
> You need to use git-add to include the new files in the commit/patch you
> sent.

Hmm, I did do that. When I did it now, git did add them again.

Please look at these newly created patches

http://home.danielnylander.se/translations/wine/wine-swedish.patch
http://home.danielnylander.se/translations/wine/add_sv_build.patch

Sorry for the noise

Patch for adding Swedish localization

[Robert Shearman]

Daniel Nylander wrote:
> Robert Shearman skrev:
> > Daniel Nylander wrote:
> > > Here is the patch to add Swedish localization files to Wine.
> > > Sorry, this is my first patch using git and I'm really unsure if I did
> > > it correctly.
> >
> > You need to use git-add to include the new files in the commit/patch you
> > sent.
>
> Hmm, I did do that. When I did it now, git did add them again.
>
> Please look at these newly created patches
>
> http://home.danielnylander.se/translations/wine/wine-swedish.patch
> http://home.danielnylander.se/translations/wine/add_sv_build.patch

You need to make one patch with both the changes to existing .rc files 
and with the new .rc files, otherwise the commit isn't atomic.

Also, don't gzip a patch unless it is over ~100KB since it makes it much 
harder to review.

Patch for adding Swedish localization

[Daniel Nylander]

Robert Shearman skrev:
> You need to make one patch with both the changes to existing .rc files
> and with the new .rc files, otherwise the commit isn't atomic.
>
> Also, don't gzip a patch unless it is over ~100KB since it makes it much
> harder to review.

Here is another shot at it.

http://home.danielnylander.se/translations/wine/0001-Adding-Swedish-localiza...

(it's 130kB now)

Patch for adding Swedish localization

[Maarten Lankhorst]

Hi Daniel,

You must add localizations for 1 dll/program at a time, that makes it a
lot easier to review.

Cheers,
Maarten.

Patch for adding Swedish localization

[Daniel Nylander]

Maarten Lankhorst skrev:
> Hi Daniel,
>
> You must add localizations for 1 dll/program at a time, that makes it a
> lot easier to review.

How do I create a patch per file? There are 28 new files that needs to
be commited and one #include per dll/program to be added. Please help me
out, I'm not a developer.

Patch for adding Swedish localization

[Maarten Lankhorst]

Daniel Nylander schreef:
> How do I create a patch per file? There are 28 new files that needs to
> be commited and one #include per dll/program to be added. Please help me
> out, I'm not a developer

If you created a git commit, you can undo it with git reset --mixed
origin. Then do the following:

git update-index --add dlls/somedll/newfile.rc dlls/somedll/existingfile.rc
git commit -m 'somedll: Add swedish translations'

Do this 28 times and then send it in.

Good luck,
Maarten.