Re: [PATCH 06/21] vbscript: Added function arguments compiler implementation

[Octavian Voicu]

On Wed, Sep 14, 2011 at 1:56 PM, Jacek Caban  wrote:
> --- a/dlls/vbscript/compile.c
> +++ b/dlls/vbscript/compile.c
> @@ -658,9 +658,26 @@ static HRESULT create_function(compile_ctx_t *ctx, function_decl_t *decl, functi
>      func->code_ctx = ctx->code;
>      func->type = decl->type;
> - func->arg_cnt = 0;
> if(decl->args) {

...
> - }else {
> -
>    decl->args = NULL;

I think you want to set func->args to NULL at the last line.

Cheers,
Octavian

[PATCH 06/21] vbscript: Added function arguments compiler implementation

[Jacek Caban]

On 09/14/11 13:47, Octavian Voicu wrote:
> On Wed, Sep 14, 2011 at 1:56 PM, Jacek Caban  wrote:
> > --- a/dlls/vbscript/compile.c
> > +++ b/dlls/vbscript/compile.c
> > @@ -658,9 +658,26 @@ static HRESULT create_function(compile_ctx_t *ctx, function_decl_t *decl, functi
> >       func->code_ctx = ctx->code;
> >       func->type = decl->type;
> > - func->arg_cnt = 0;
> >  if(decl->args) {
>
> ...
> > - }else {
> > -
> >    decl->args = NULL;
>
> I think you want to set func->args to NULL at the last line.

Yeah, good catch, thanks.

Jacek