Re: [PATCH 2/2] jscript: Added lastIndex tests.

[Paul Vriens]

On 11/30/2009 09:12 PM, Jacek Caban wrote:
> dlls/jscript/tests/regexp.js | 66
> ++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 66 insertions(+), 0 deletions(-)

Hi Jacek,

This one introduces test failures on Vista+ :

http://test.winehq.org/data/tests/jscript:run.html

Could you have a look?

[PATCH 2/2] jscript: Added lastIndex tests.

[Jacek Caban]

Paul Vriens wrote:
> On 11/30/2009 09:12 PM, Jacek Caban wrote:
> > dlls/jscript/tests/regexp.js | 66
> > ++++++++++++++++++++++++++++++++++++++++++
> > 1 files changed, 66 insertions(+), 0 deletions(-)
>
> Hi Jacek,
>
> This one introduces test failures on Vista+ :
>
> http://test.winehq.org/data/tests/jscript:run.html
>
> Could you have a look?

That's strange, I can't reproduce it on my XP with IE8 nor IE7. The 
debug output is not enough to find, which exactly test fails. Could you 
please run it with attached patch?

Thanks,
    Jacek

diff --git a/dlls/jscript/tests/regexp.js b/dlls/jscript/tests/regexp.js
index bcc9aba..a1be281 100644
--- a/dlls/jscript/tests/regexp.js
+++ b/dlls/jscript/tests/regexp.js
@@ -302,7 +302,7 @@ re = /a/g;
 ok(re.lastIndex === 0, "re.lastIndex = " + re.lastIndex + " expected 0");

m = re.exec(" a   ");
-ok(re.lastIndex === 2, "re.lastIndex = " + re.lastIndex + " expected 2");
+ok(re.lastIndex === 2, "re.lastIndex = " + re.lastIndex + " expected 2 [1]");
 ok(m.index === 1, "m.index = " + m.index + " expected 1");

m = re.exec(" a   ");
@@ -328,14 +328,14 @@ re.lastIndex = obj;
 ok(re.lastIndex === obj, "re.lastIndex = " + re.lastIndex + " expected obj");
 li = 2;
 m = re.exec(" a a ");
-ok(re.lastIndex === 2, "re.lastIndex = " + re.lastIndex + " expected 2");
+ok(re.lastIndex === 2, "re.lastIndex = " + re.lastIndex + " expected 2 [2]");
 ok(m.index === 1, "m.index = " + m.index + " expected 1");

re.lastIndex = 3;
 re.lastIndex = "test";
 ok(re.lastIndex === "test", "re.lastIndex = " + re.lastIndex + " expected 'test'");
 m = re.exec(" a a ");
-ok(re.lastIndex === 2, "re.lastIndex = " + re.lastIndex + " expected 2");
+ok(re.lastIndex === 2, "re.lastIndex = " + re.lastIndex + " expected 2 [3]");
 ok(m.index === 1, "m.index = " + m.index + " expected 1");

re.lastIndex = 0;
@@ -349,7 +349,7 @@ obj.valueOf = function() { throw 0; }
 re.lastIndex = obj;
 ok(re.lastIndex === obj, "unexpected re.lastIndex");
 m = re.exec(" a a ");
-ok(re.lastIndex === 2, "re.lastIndex = " + re.lastIndex + " expected 2");
+ok(re.lastIndex === 2, "re.lastIndex = " + re.lastIndex + " expected 2 [4]");
 ok(m.index === 1, "m.index = " + m.index + " expected 1");

re.lastIndex = -3;

[PATCH 2/2] jscript: Added lastIndex tests.

[Paul Vriens]

On 12/01/2009 08:11 PM, Jacek Caban wrote:
> Paul Vriens wrote:
> > On 11/30/2009 09:12 PM, Jacek Caban wrote:
> > > dlls/jscript/tests/regexp.js | 66
> > > ++++++++++++++++++++++++++++++++++++++++++
> > > 1 files changed, 66 insertions(+), 0 deletions(-)
> >
> > Hi Jacek,
> >
> > This one introduces test failures on Vista+ :
> >
> > http://test.winehq.org/data/tests/jscript:run.html
> >
> > Could you have a look?
>
> That's strange, I can't reproduce it on my XP with IE8 nor IE7. The
> debug output is not enough to find, which exactly test fails. Could you
> please run it with attached patch?
>
> Thanks,
> Jacek

Hi Jacek,

I will, but ...

Are you able to crosscompile the tests? If so you should maybe get an 
account at https://winetestbot.geldorp.nl/index.pl.

Here you find the results:

https://winetestbot.geldorp.nl/JobDetails.pl?Key=26

[PATCH 2/2] jscript: Added lastIndex tests.

[Jacek Caban]

Paul Vriens wrote:
> On 12/01/2009 08:11 PM, Jacek Caban wrote:
> > Paul Vriens wrote:
> > > On 11/30/2009 09:12 PM, Jacek Caban wrote:
> > > > dlls/jscript/tests/regexp.js | 66
> > > > ++++++++++++++++++++++++++++++++++++++++++
> > > > 1 files changed, 66 insertions(+), 0 deletions(-)
> > >
> > > Hi Jacek,
> > >
> > > This one introduces test failures on Vista+ :
> > >
> > > http://test.winehq.org/data/tests/jscript:run.html
> > >
> > > Could you have a look?
> >
> > That's strange, I can't reproduce it on my XP with IE8 nor IE7. The
> > debug output is not enough to find, which exactly test fails. Could you
> > please run it with attached patch?
> >
> > Thanks,
> > Jacek
>
> Hi Jacek,
>
> I will, but ...
>
> Are you able to crosscompile the tests? If so you should maybe get an 
> account at https://winetestbot.geldorp.nl/index.pl.

Right, I forgot about it. I will give it a try.

Thanks,
    Jacek