Signed-off-by: Sven Baars sven.wine@gmail.com --- dlls/kernel32/tests/actctx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dlls/kernel32/tests/actctx.c b/dlls/kernel32/tests/actctx.c index 2b8c3d710a..0dad5cb785 100644 --- a/dlls/kernel32/tests/actctx.c +++ b/dlls/kernel32/tests/actctx.c @@ -3303,8 +3303,8 @@ static void get_application_directory(char *buffer, int buffer_size) /* Test loading two sxs dlls at the same time */ static void test_two_dlls_at_same_time(void) { - sxs_info dll_1; - sxs_info dll_2; + sxs_info dll_1 = {0}; + sxs_info dll_2 = {0}; char path1[MAX_PATH], path2[MAX_PATH];
if (!fill_sxs_info(&dll_1, "1", "dummy.dll", two_dll_manifest_exe, two_dll_manifest_dll, TRUE))
Sven Baars sven.wine@gmail.com writes:
Signed-off-by: Sven Baars sven.wine@gmail.com
dlls/kernel32/tests/actctx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dlls/kernel32/tests/actctx.c b/dlls/kernel32/tests/actctx.c index 2b8c3d710a..0dad5cb785 100644 --- a/dlls/kernel32/tests/actctx.c +++ b/dlls/kernel32/tests/actctx.c @@ -3303,8 +3303,8 @@ static void get_application_directory(char *buffer, int buffer_size) /* Test loading two sxs dlls at the same time */ static void test_two_dlls_at_same_time(void) {
- sxs_info dll_1;
- sxs_info dll_2;
- sxs_info dll_1 = {0};
- sxs_info dll_2 = {0};
It would be better to make sure that fill_sxs_info() initializes things correctly, instead of zeroing everything to hide the bug.
On 27-09-19 17:51, Alexandre Julliard wrote:
It would be better to make sure that fill_sxs_info() initializes things correctly, instead of zeroing everything to hide the bug.
It does fill it correctly, but never gets called for dll_2 because CreateActCtxA fails on XP (as stated in fill_sxs_info). I initialized both to 0 to make it look more consistent, but only dll_2 actually has to be initialized to 0.
Sven
-
Alexandre Julliard -
Sven Baars