Rein Klazes schreef:
Hi,
Proposed fix for some problems mentioned in the previous patch.
I hope putting the logic in menu.c is an acceptable way to cross the window<->menu border. If you want it somewhere else, let me know.
Rein.
Several rounds of commits have gone by. Still not commited, no objections or comments to this patch and the accompanying test.
Is there anything that I can do to get this moving forward?
Rein.
2009/3/13 Rein Klazes wijn@online.nl:
Several rounds of commits have gone by. Still not commited, no objections or comments to this patch and the accompanying test.
Is there anything that I can do to get this moving forward?
Try the #winehackers IRC on freenode.
Also, I suggested you should use a message sequence in the tests instead of using global variables and a window procedure to see if messages are called.
There is a checklist that Alexandre uses to judge patches before he accepts them. I can't remember the link to this, though.
- Reece
Reece Dunn schreef:
There is a checklist that Alexandre uses to judge patches before he accepts them. I can't remember the link to this, though.
- Reece
I can not remember this checklist, I would be interested if you find it.
And I think the delay has to do with the nature of this patch: until now the window handling does not know too much about the menu internals. It might take some convincing that this it necessary or Alexandre may have other ideas how to do that.
Rein.