Re: [PATCH 14/21] api-ms-win-crt-multibyte-l1-1-0: Add stub dll.

[Sebastian Lackner]

On 23.07.2015 21:47, Martin Storsjo wrote:
> +@ stdcall __p__mbcasemap() ucrtbase.__p__mbcasemap

This (and a couple of other redirects) should probably be declared as cdecl, similar to how its done in all other msvcr* dlls.
You have to update the hack in tools/make_specfiles for this to work properly, for example like that:

--- snip ---
@@ -376,7 +376,7 @@ sub update_spec_file($)
         if ($parent{callconv} ne "stub" || $parent{args})
         {
             my $callconv = $parent{callconv} ne "stub" ? $parent{callconv} :
-                           $parent{spec} =~ /msvc/ ? "cdecl" : "stdcall";  # hack
+                           $parent{spec} =~ /(msvc|ucrtbase)/ ? "cdecl" : "stdcall";  # hack
             $_ = sprintf "$descr{ordinal} %s %s%s", $callconv, $flags, $func;

if ($parent{target} =~ /$group_head./)  # use the same forward as parent if possible
--- snip ---

Please note that this is the first patch affected by this problem.

[PATCH 14/21] api-ms-win-crt-multibyte-l1-1-0: Add stub dll.

[Martin Storsjö]

Hi,

On Fri, 24 Jul 2015, Sebastian Lackner wrote:
> On 23.07.2015 21:47, Martin Storsjo wrote:
> > +@ stdcall __p__mbcasemap() ucrtbase.__p__mbcasemap
>
> This (and a couple of other redirects) should probably be declared as cdecl, similar to how its done in all other msvcr* dlls.
> You have to update the hack in tools/make_specfiles for this to work properly, for example like that:
>
> --- snip ---
> @@ -376,7 +376,7 @@ sub update_spec_file($)
>         if ($parent{callconv} ne "stub" || $parent{args})
>         {
>             my $callconv = $parent{callconv} ne "stub" ? $parent{callconv} :
> -
>                       $parent{spec} =~ /msvc/ ? "cdecl" : "stdcall";  # hack
> -
>                       $parent{spec} =~ /(msvc|ucrtbase)/ ? "cdecl" : "stdcall";  # hack
>       $_ = sprintf "$descr{ordinal} %s %s%s", $callconv, $flags, $func;
>
>       if ($parent{target} =~ /$group_head\./)  # use the same forward as parent if possible
>
> --- snip ---

Thanks, will do. Perhaps vcruntime also should be added here? I'll await 
more comments before resubmitting the patchset since it's pretty large...

// Martin