[PATCH v2] wininet: Free security context in failure case.

[Daniel Lehman]

Signed-off-by: Daniel Lehman 
---
v2: invalidate handle after free
---
 dlls/wininet/netconnection.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/dlls/wininet/netconnection.c b/dlls/wininet/netconnection.c
index 4ad22177ee..c8bb3973e7 100644
--- a/dlls/wininet/netconnection.c
+++ b/dlls/wininet/netconnection.c
@@ -573,6 +573,10 @@ static DWORD netcon_secure_connect_setup(netconn_t *connection, BOOL compat_mode
         WARN("Failed to establish SSL connection: %08x (%u)\n", status, res);
         heap_free(connection->ssl_buf);
         connection->ssl_buf = NULL;
+        if(SecIsValidHandle(&connection->ssl_ctx)) {
+            DeleteSecurityContext(&connection->ssl_ctx);
+            SecInvalidateHandle(&connection->ssl_ctx);
+        }
         return res ? res : ERROR_INTERNET_SECURITY_CHANNEL_ERROR;
     }

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=45160

Your paranoid android.

=== debian9 (32 bit report) ===

wininet:
Unhandled exception: page fault on read access to 0x0000001b in 32-bit code (0x7e18eedd).

Report errors:
wininet:http crashed (c0000005)

=== debian9 (32 bit Chinese:China report) ===

wininet:
Unhandled exception: page fault on read access to 0x0000001b in 32-bit code (0x7d4f1edd).

Report errors:
wininet:http crashed (c0000005)

=== debian9 (32 bit WoW report) ===

wininet:
Unhandled exception: page fault on read access to 0x0000001b in 32-bit code (0xf71f1edd).

Report errors:
wininet:http crashed (c0000005)

=== debian9 (64 bit WoW report) ===

wininet:
Unhandled exception: page fault on read access to 0x0000002f in 64-bit code (0x00007fd9a86c6aa8).

Report errors:
wininet:http crashed (c0000005)