Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19922
Your paranoid android.
=== wvistau64 (32 bit shlexec) === shlexec.c:1610: Test failed: WaitForSingleObject returned 258 shlexec.c:1639: Test failed: argvA3 expected 'QuotedLowerL', got 'Open' shlexec.c:1647: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtDA95.tmp\test file.shlexec', got 'C:\Users\winetest\AppData\Local\Temp\wtDA95.tmp\test file.noassoc.shlexec'
=== w1064 (32 bit shlexec) === shlexec.c:2356: Test failed: failed: rc=29 err=2 shlexec.c:2356: Test failed: failed: rc=29 err=2 shlexec.c:2356: Test failed: failed: rc=29 err=2 shlexec.c:2356: Test failed: failed: rc=29 err=2
=== w1064 (64 bit shlexec) === shlexec.c:2356: Test failed: failed: rc=29 err=2 shlexec.c:2356: Test failed: failed: rc=29 err=2 shlexec.c:2356: Test failed: failed: rc=29 err=2 shlexec.c:2368: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wt4F7B.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wt4F7B.tmp\test file.sde")]' shlexec.c:2356: Test failed: failed: rc=29 err=2 shlexec.c:2356: Test failed: failed: rc=29 err=2
On Fri, 22 Jan 2016, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19922
Your paranoid android.
=== wvistau64 (32 bit shlexec) ===
Called ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtDA95.tmp\test file.noassoc.shlexec") shlexec.c:1610: Test failed: WaitForSingleObject returned 258 shlexec.c:1592: Tests skipped: Skipping shellexecute of file with unassociated extension shlexec.c:1592: Tests skipped: Skipping shellexecute of file with unassociated extension Called ShellExecute(verb="QuotedLowerL", file="C:\Users\winetest\AppData\Local\Temp\wtDA95.tmp\test file.shlexec") shlexec.c:1639: Test failed: argvA3 expected 'QuotedLowerL', got 'Open' shlexec.c:1647: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtDA95.tmp\test file.shlexec', got 'C:\Users\winetest\AppData\Local\Temp\wtDA95.tmp\test file.noassoc.shlexec'
What seems to be happening here is that starting the child process in the first ShellExecute() call took too long. As a result the first test hit the 5 second timeout and skipped to the next test. So we had a race condition between the two child processes and we got the results from the wrong one, causing the other two failures.
It's not clear why things took so long in the first test. An hypothesis is some random activity unrelated to the test but this timeout seems to specifically hit this .noassoc.shlexec test, on this specific VM and only in 32 bit mode.
Yet this same test can run in as little as 15ms at other times so even an occasional jump to 5600ms seems like a lot.
=== w1064 (32 bit shlexec) === shlexec.c:2356: Test failed: failed: rc=29 err=2 shlexec.c:2356: Test failed: failed: rc=29 err=2 shlexec.c:2356: Test failed: failed: rc=29 err=2 shlexec.c:2356: Test failed: failed: rc=29 err=2
=== w1064 (64 bit shlexec) === shlexec.c:2356: Test failed: failed: rc=29 err=2 shlexec.c:2356: Test failed: failed: rc=29 err=2 shlexec.c:2356: Test failed: failed: rc=29 err=2 shlexec.c:2368: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wt4F7B.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wt4F7B.tmp\test file.sde")]' shlexec.c:2356: Test failed: failed: rc=29 err=2 shlexec.c:2356: Test failed: failed: rc=29 err=2
Still not sure about those. This is specific to Windows 10.
-
Francois Gouget -
Marvin