Re: Fix compile of programs/winedbg/elf.c on NetBSD 1.6

[Eric Pouech]

Yorick Hardy a écrit :
> Changelog: Use SHN_UNDEF instead of STN_UNDEF when it is defined
>            and STN_UNDEF is not. Fixes compiling on NetBSD 1.6.
>
> Kind regards,

both STN_UNDEF and SHN_UNDEF exist in ELF definition and are meant to be 
used in different cases, which your patch mixes. Hence the fix is wrong 
(even if by change STN_UNDEF and SHN_UNDEF both are defined as 0)
So, I'd rather suggest something (at the top of the file) as
#ifndef STN_UNDEF
# define STN_UNDEF 0
#endif

A+

Fix compile of programs/winedbg/elf.c on NetBSD 1.6

[Yorick Hardy]

Thanks for your input. It is very likely that I misunderstood, but I found
the following in /usr/include/elf.h on NetBSD 1.6

/*
   * Symbol Table
   */
  typedef struct {
  ...
          Elf32_Half      st_shndx;       /* section index of symbol */
  } Elf32_Sym;

...

/*
   * Special section indexes
   */
  #define SHN_UNDEF       0               /* Undefined section */

Is this consistent with what you said? If so, I can try submit
what you suggested tonight.

Kind regards,

Yorick Hardy.
> Yorick Hardy a écrit :
> > Changelog: Use SHN_UNDEF instead of STN_UNDEF when it is defined
> >            and STN_UNDEF is not. Fixes compiling on NetBSD 1.6.
> >
> > Kind regards,
>
> both STN_UNDEF and SHN_UNDEF exist in ELF definition and are meant to be
> used in different cases, which your patch mixes. Hence the fix is wrong
> (even if by change STN_UNDEF and SHN_UNDEF both are defined as 0)
> So, I'd rather suggest something (at the top of the file) as
> #ifndef STN_UNDEF
> # define STN_UNDEF 0
> #endif
>
> A+

--------------------------------------------------------
This message was sent using MetroWEB's AirMail service.
http://www.metroweb.co.za/ - full access for only R59.
Free WebMail, Calendar, Anti-Virus, Anti-Spam, 10 emails
Phone Now!  086 11 11 440

Fix compile of programs/winedbg/elf.c on NetBSD 1.6

[Eric Pouech]

Yorick Hardy a écrit :
> Thanks for your input. It is very likely that I misunderstood, but I found
> the following in /usr/include/elf.h on NetBSD 1.6

[snip]
> Is this consistent with what you said?

seems like i misread some of the ELF specs. Your fix is right (sorry for 
the noise). BTW, you could also remove the use of STN_UNDEF in elf.c 
while you're at it.
A+

Fix compile of programs/winedbg/elf.c on NetBSD 1.6

[Yorick Hardy]

> seems like i misread some of the ELF specs. Your fix is right (sorry for 
> the noise). BTW, you could also remove the use of STN_UNDEF in elf.c 
> while you're at it.

Not to worry, I am now more confused than ever :-).
By the way, what is STN_UNDEF for ?

Changelog: Use SHN_UNDEF instead of STN_UNDEF to specify undefined
           section index.

Kind regards,

Fix compile of programs/winedbg/elf.c on NetBSD 1.6

[Eric Pouech]

Yorick Hardy a écrit :
> Not to worry, I am now more confused than ever :-).
> By the way, what is STN_UNDEF for ?

it's used as an index in the Elf32_Sym array to identify the undefined 
symbol, whereas SHN_UNDEF is a potential value of Elf32_Sym.st_shndx 
(which is the section in which the symbol is defined), and refers to the 
undefined section (for undefined symbols)

A+