Re: [PATCH 1/2] kernel32: threadpool definitions and prototypes

[Dmitry Timoshkov]

Marcus Meissner  wrote:
> +#define WINPR_API WINBASEAPI

This definition doesn't exist in PSDK 7.1.
> +typedef DWORD TP_VERSION,*PTP_VERSION;

PSDK 7.1 has this one and many other definitions in winnt.h instead.

[PATCH 1/2] kernel32: threadpool definitions and prototypes

[Marcus Meissner]

On Mon, Jan 27, 2014 at 12:21:21AM +0900, Dmitry Timoshkov wrote:
> Marcus Meissner  wrote:
> > +#define WINPR_API WINBASEAPI
>
> This definition doesn't exist in PSDK 7.1.

hmm, ok, can redo.
> > +typedef DWORD TP_VERSION,*PTP_VERSION;
>
> PSDK 7.1 has this one and many other definitions in winnt.h instead.

Hmm. MSDN says differently:

http://msdn.microsoft.com/en-us/library/windows/desktop/ms687053%28v=vs.85%2...

WinBase.h on Windows Vista, Windows 7, Windows Server 2008, and Windows Server 2008 R2 (include Windows.h);
Threadpoolapiset.h on Windows 8 and Windows Server 2012

So where should I move it?

Ciao, Marcus

[PATCH 1/2] kernel32: threadpool definitions and prototypes

[Nikolay Sivov]

On 1/26/2014 19:36, Marcus Meissner wrote:
> > > +typedef DWORD TP_VERSION,*PTP_VERSION;
> >
> > PSDK 7.1 has this one and many other definitions in winnt.h instead.
>
> Hmm. MSDN says differently:
>
> http://msdn.microsoft.com/en-us/library/windows/desktop/ms687053%28v=vs.85%2...
>
> WinBase.h on Windows Vista, Windows 7, Windows Server 2008, and Windows Server 2008 R2 (include Windows.h);
> Threadpoolapiset.h on Windows 8 and Windows Server 2012
>
> So where should I move it?

I checked SDK 6.0, 7.0, 7.1 and 8.0, all of these have it in winnt.h
> Ciao, Marcus

[PATCH 1/2] kernel32: threadpool definitions and prototypes

[Dmitry Timoshkov]

Marcus Meissner  wrote:
> > > +typedef DWORD TP_VERSION,*PTP_VERSION;
> >
> > PSDK 7.1 has this one and many other definitions in winnt.h instead.
>
> Hmm. MSDN says differently:
>
> http://msdn.microsoft.com/en-us/library/windows/desktop/ms687053%28v=vs.85%2...
>
> WinBase.h on Windows Vista, Windows 7, Windows Server 2008, and Windows Server 2008 R2 (include Windows.h);
> Threadpoolapiset.h on Windows 8 and Windows Server 2012

It would be better to check actual PSDK headers instead of online docs.