Re: [2/2] winex11: Don't use context-specific info when initializing

[Christoph Frick]

On Fri, Aug 10, 2007 at 02:29:49AM -0700, Chris Robinson wrote:

@@ -137,7 +132,7 @@ typedef struct wine_glpbuffer {
 } Wine_GLPBuffer;

static Wine_GLContext *context_list;
-static struct WineGLInfo WineGLInfo = { 0 };
+static struct WineGLInfo WineGLInfo;
 static int use_render_texture_emulation = 1;
 static int use_render_texture_ati = 0;
 static int swap_interval = 1;

why is this changed? its a Good Thing to have global structs initialized so
they fail earlier under abuse.

[2/2] winex11: Don't use context-specific info when initializing

[Chris Robinson]

On Friday 10 August 2007 02:35:59 am Christoph Frick wrote:
> On Fri, Aug 10, 2007 at 02:29:49AM -0700, Chris Robinson wrote:
>
> @@ -137,7 +132,7 @@ typedef struct wine_glpbuffer {
>  } Wine_GLPBuffer;
>
> static Wine_GLContext *context_list;
> -static struct WineGLInfo WineGLInfo = { 0 };
> +static struct WineGLInfo WineGLInfo;
>  static int use_render_texture_emulation = 1;
>  static int use_render_texture_ati = 0;
>  static int swap_interval = 1;
>
> why is this changed? its a Good Thing to have global structs initialized so
> they fail earlier under abuse.

The first field was changed from a const char* to an int[2], so it'd at least 
need to be changed to { { 0 } } to avoid compiler warnings. But considering 
it's global, and global variables are automatically cleared to 0, there's no 
need to be explicit about setting it to 0.