Problem with older wgl patch

[Tim Savannah]

On the newest wine, trying to start opengl programs such as World of
Warcraft yields an error such as this:

trace:opengl:wine_glCullFace (1029)
trace:opengl:wine_glMatrixMode (5889)
trace:opengl:wine_glLoadMatrixf (0x7fbafbb8)
trace:opengl:wglMakeCurrent (0x368,0x7fd7b7d0)
trace:opengl:create_glxpixmap return 1800054
trace:opengl:wglMakeCurrent  make current for dis 0x7c01baf8, drawable
0x1800054, ctx 0x7c1c01d8
X Error of failed request:  BadMatch (invalid parameter attributes)
  Major opcode of failed request:  144 (GLX)
  Minor opcode of failed request:  13 (X_GLXCreateGLXPixmap)
  Serial number of failed request:  412
  Current serial number in output stream:  413

I don't know enough about wgl to offer any suggestions to the problem, other
than the source seems to be this patch:
http://cvs.winehq.org/cvsweb/wine/dlls/opengl32/wgl.c.diff?r1=1.71&r2=1....

Reverting that patch and adding

+  DWORD type = GetObjectType(hdc);

where that patch placed it in the file allows opengl to work again.

[Aric Cyr]

Tim Savannah <kata198 <at> gmail.com> writes:
> - DWORD type = GetObjectType(hdc);where that patch placed it in the file
>
> allows opengl to work again.

I think this is fixed in CVS already.  Which version of wine are you trying with?
Try out the latest CVS if you can.

- Aric

[Tomas Carnecky]

Aric Cyr wrote:
> Tim Savannah <kata198 <at> gmail.com> writes:
> > - DWORD type = GetObjectType(hdc);where that patch placed it in the file
> >
> > allows opengl to work again.
>
> I think this is fixed in CVS already.  Which version of wine are you trying with?
> Try out the latest CVS if you can.

Just tried latest version from git and the compilation fails because 
'type' is undefined. How often is git updated from CVS? Or do the 
developers check-in directly into git?

tom

[Alexandre Julliard]

Tomas Carnecky  writes:
> Just tried latest version from git and the compilation fails because
> 'type' is undefined. How often is git updated from CVS? Or do the
> developers check-in directly into git?

Yes, I commit directly into git. All commits are immediately mirrored
into CVS, so 'latest git' and 'latest cvs' are always the same thing.