Re: Fix in Variant's coerce function

[Alexandre Julliard]

Francois Gouget  writes:
> It seemed wrong, as did the 32 suffixes, and leaving all the
> xxxFromDisp functions commented out.

It may be a good idea to actually implement the functions before
uncommenting the calls ;-)

Fix in Variant's coerce function

[Francois Gouget]

On 18 May 2001, Alexandre Julliard wrote:
> Francois Gouget  writes:
> > It seemed wrong, as did the 32 suffixes, and leaving all the
> > xxxFromDisp functions commented out.
>
> It may be a good idea to actually implement the functions before
> uncommenting the calls ;-)

On the other hand at least you would quickly notice that the function
is being used and that you should stub it out. Currently you would get
an error code and no message in the log so that you may not notice.
   What also bothers me is that the person implementing the xxxFromDisp
functions has an 80% chance of forgetting to update the Coerce function.

So I'm in favor of uncommenting the calls in Coerce, and if these
cases are really being used then either we do a full-fledged
implementation or we write pseudo-stubs for these functions.

Do we have a know app that crashes with this patch?

--
Francois Gouget         [e-mail]        http://fgouget.free.fr/
                         "Utilisateur" (nom commun) :
        Mot utilisé par les informaticiens en lieu et place d'"idiot".