Re: Dmitry Timoshkov : dwrite/tests: Add some fallback tests for Segoe UI Symbol.

[Eric Pouech]

Hi Dmitry
+ hr = IDWriteFontFallback_MapCharacters(fallback, &analysissource, 0, 
1, NULL, NULL, DWRITE_FONT_WEIGHT_NORMAL,
> -
>            DWRITE_FONT_STYLE_NORMAL, DWRITE_FONT_STRETCH_NORMAL, &length, &font, &scale);
> - todo_wine
> -
>    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
> -
>    if (hr != S_OK) continue;

would you mind not outdenting the todo_wine... it generates tons of 
FIXME with mingw's GCC11
TIA

Dmitry Timoshkov : dwrite/tests: Add some fallback tests for Segoe UI Symbol.

[Nikolay Sivov]

On 4/6/22 09:55, Eric Pouech wrote:
> Hi Dmitry
> - hr = IDWriteFontFallback_MapCharacters(fallback, &analysissource, 0,
>
> 1, NULL, NULL, DWRITE_FONT_WEIGHT_NORMAL,
> > +                DWRITE_FONT_STYLE_NORMAL, 
> > DWRITE_FONT_STRETCH_NORMAL, &length, &font, &scale);
> > +    todo_wine
> > +        ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
> > +        if (hr != S_OK) continue;
>
> would you mind not outdenting the todo_wine... it generates tons of 
> FIXME with mingw's GCC11
> TIA

Is that with recent mingw-w64? I only use that for tests, whatever 
version debian testing has at the moment, currently reported as

x86_64-w64-mingw32-gcc (GCC) 10-win32 20220113

Until this triggers warnings I'll probably won't notice.

Dmitry Timoshkov : dwrite/tests: Add some fallback tests for Segoe UI Symbol.

[Eric Pouech]

Le 06/04/2022 à 09:17, Nikolay Sivov a écrit :
> On 4/6/22 09:55, Eric Pouech wrote:
> > Hi Dmitry
> > - hr = IDWriteFontFallback_MapCharacters(fallback, &analysissource,
> >
> > 0, 1, NULL, NULL, DWRITE_FONT_WEIGHT_NORMAL,
> > > - DWRITE_FONT_STYLE_NORMAL, DWRITE_FONT_STRETCH_NORMAL, &length,
> > >
> > > &font, &scale);
> > > +    todo_wine
> > > +        ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
> > > +        if (hr != S_OK) continue;
> >
> > would you mind not outdenting the todo_wine... it generates tons of 
> > FIXME with mingw's GCC11
> > TIA
>
> Is that with recent mingw-w64? I only use that for tests, whatever 
> version debian testing has at the moment, currently reported as
>
> x86_64-w64-mingw32-gcc (GCC) 10-win32 20220113
>
> Until this triggers warnings I'll probably won't notice.

afaics Debian uses gcc11 for ELF compilation but hasn't updated yet 
mingw port to gcc11 (keeps GCC10)

for info, fedora (current = 35) uses gcc11 and mingw gcc11. next version 
(fedora36 under beta test right now) uses gcc12 and mingw-gcc11... and 
this will trigger a new load of warnings (I'm still waiting for tackling 
them that gcc 12 is officially released and integrated in f36)